Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 68 additions & 59 deletions apps/owner/src/app/(tabs)/mypage/store-info/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import { Button, Header } from "@compasser/design-system";
import type {
StoreUpdateReqDTO,
StoreLocationUpdateReqDTO,
StoreTag,
BankType,
} from "@compasser/api";

import StoreNameField from "@/app/signup/register/_components/fields/StoreNameField";
Expand All @@ -18,13 +20,14 @@ import PhotoUploadSection from "@/app/signup/register/_components/sections/Photo
import TagSection from "@/app/signup/register/_components/sections/TagSection";
import BusinessHoursModal from "@/app/signup/register/_components/modals/BusinessHoursModal";
import RandomBoxModal from "@/app/signup/register/_components/modals/RandomBoxModal";
import AddressSearchBottomSheet from "@/app/signup/register/_components/AddressSearchBottomSheet";
import type { AddressSearchItem } from "@/app/signup/register/_types/address-search";

import { useMyStoreQuery } from "@/shared/queries/query/useMyStoreQuery";
import { usePatchMyStoreMutation } from "@/shared/queries/mutation/auth/usePatchMyStoreMutation";
import { usePatchMyStoreLocationMutation } from "@/shared/queries/mutation/auth/usePatchMyStoreLocationMutation";
import { useRandomBoxListQuery } from "@/shared/queries/query/useRandomBoxListQuery";
import { useCreateRandomBoxMutation } from "@/shared/queries/mutation/auth/useCreateRandomBoxMutation";
import { useUpdateRandomBoxMutation } from "@/shared/queries/mutation/auth/useUpdateRandomBoxMutation";
import { useDeleteRandomBoxMutation } from "@/shared/queries/mutation/auth/useDeleteRandomBoxMutation";
import { useStoreImageQuery } from "@/shared/queries/query/useStoreImageQuery";
import { useUploadStoreImageMutation } from "@/shared/queries/mutation/auth/useUploadStoreImageMutation";
Expand All @@ -35,7 +38,21 @@ import {
EMPTY_BUSINESS_HOURS,
} from "@/app/signup/register/_utils/business-hours";

type FixedTag = "카페" | "베이커리" | "식당";
const tagOptions = ["카페", "베이커리", "식당"] as const;

type TagLabel = (typeof tagOptions)[number];

const tagMap: Record<TagLabel, StoreTag> = {
카페: "CAFE",
베이커리: "BAKERY",
식당: "RESTAURANT",
};

const reverseTagMap: Record<StoreTag, TagLabel> = {
CAFE: "카페",
BAKERY: "베이커리",
RESTAURANT: "식당",
};

export default function StoreInfoEditPage() {
const router = useRouter();
Expand All @@ -49,54 +66,39 @@ export default function StoreInfoEditPage() {
const patchMyStoreMutation = usePatchMyStoreMutation();
const patchMyStoreLocationMutation = usePatchMyStoreLocationMutation();
const createRandomBoxMutation = useCreateRandomBoxMutation();
const updateRandomBoxMutation = useUpdateRandomBoxMutation();
const deleteRandomBoxMutation = useDeleteRandomBoxMutation();
const uploadStoreImageMutation = useUploadStoreImageMutation();
const removeStoreImageMutation = useRemoveStoreImageMutation();

const [storeName, setStoreName] = useState("");
const [storeEmail, setStoreEmail] = useState("");
const [inputAddress, setInputAddress] = useState("");
const [bankName, setBankName] = useState("");
const [bankType, setBankType] = useState<BankType | "">("");
const [depositor, setDepositor] = useState("");
const [bankAccount, setBankAccount] = useState("");
const [businessHours, setBusinessHours] = useState(EMPTY_BUSINESS_HOURS);

const tagOptions: FixedTag[] = ["카페", "베이커리", "식당"];
const [selectedTag, setSelectedTag] = useState<FixedTag | "">("");

const [selectedRandomBoxIds, setSelectedRandomBoxIds] = useState<number[]>(
[],
);
const [isBusinessHoursModalOpen, setIsBusinessHoursModalOpen] =
useState(false);
const [selectedTag, setSelectedTag] = useState<"" | TagLabel>("");
const [selectedRandomBoxIds, setSelectedRandomBoxIds] = useState<number[]>([]);
const [isBusinessHoursModalOpen, setIsBusinessHoursModalOpen] = useState(false);
const [isRandomBoxModalOpen, setIsRandomBoxModalOpen] = useState(false);
const [isAddressSearchOpen, setIsAddressSearchOpen] = useState(false);

const [photoFile, setPhotoFile] = useState<File | null>(null);
const [photoPreviewUrl, setPhotoPreviewUrl] = useState("");
const [imageRemoved, setImageRemoved] = useState(false);

const mapStoreTagToLabel = (tag: string | undefined): FixedTag | "" => {
switch (tag) {
case "CAFE":
return "카페";
case "BAKERY":
return "베이커리";
case "RESTAURANT":
return "식당";
default:
return "";
}
};

useEffect(() => {
if (!myStore) return;

setStoreName(myStore.storeName ?? "");
setStoreEmail("");
setStoreEmail(myStore.storeEmail ?? "");
setInputAddress(myStore.inputAddress ?? "");
setBusinessHours(parseBusinessHours(myStore.businessHours));
setSelectedTag(mapStoreTagToLabel(myStore.tag));

if (myStore.tag) {
setSelectedTag(reverseTagMap[myStore.tag as StoreTag] ?? "");
}
}, [myStore]);
Comment on lines 91 to 102

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

기존 계좌 정보가 초기화되지 않아 저장 시 값이 지워집니다.

이 effect에서 bankType, depositor, bankAccount를 로컬 상태로 옮기지 않고 있어서 수정 화면이 빈 값으로 열립니다. 사용자가 해당 필드를 건드리지 않고 저장하면 기존 계좌 정보가 "" / undefined로 덮일 수 있습니다.

🔧 수정 예시
  useEffect(() => {
    if (!myStore) return;

    setStoreName(myStore.storeName ?? "");
    setStoreEmail(myStore.storeEmail ?? "");
    setInputAddress(myStore.inputAddress ?? "");
+    setBankType(myStore.bankType ?? "");
+    setDepositor(myStore.depositor ?? "");
+    setBankAccount(myStore.bankAccount ?? "");
    setBusinessHours(parseBusinessHours(myStore.businessHours));

    if (myStore.tag) {
      setSelectedTag(reverseTagMap[myStore.tag as StoreTag] ?? "");
    }
  }, [myStore]);
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@apps/owner/src/app/`(tabs)/mypage/store-info/page.tsx around lines 91 - 102,
The effect watching myStore doesn't initialize bank account fields so saving can
overwrite existing values; update the useEffect that runs when myStore changes
(the function using setStoreName, setStoreEmail, setInputAddress,
setBusinessHours and setSelectedTag) to also setBankType(myStore.bankType ??
""), setDepositor(myStore.depositor ?? ""), and
setBankAccount(myStore.bankAccount ?? "") (or corresponding local state setters)
so the local state mirrors existing myStore values and untouched fields are not
saved as empty/undefined.


useEffect(() => {
Expand All @@ -105,6 +107,16 @@ export default function StoreInfoEditPage() {
}, [storeImage, imageRemoved]);

const businessHoursRows = useMemo(() => {
const dayKeyMap = {
mon: "MON",
tue: "TUE",
wed: "WED",
thu: "THU",
fri: "FRI",
sat: "SAT",
sun: "SUN",
} as const;

const dayLabelMap = {
mon: "월",
tue: "화",
Expand All @@ -115,19 +127,14 @@ export default function StoreInfoEditPage() {
sun: "일",
} as const;

const orderedDays = [
"mon",
"tue",
"wed",
"thu",
"fri",
"sat",
"sun",
] as const;
const orderedDays = ["mon", "tue", "wed", "thu", "fri", "sat", "sun"] as const;

return orderedDays.map((day) => {
const value = businessHours[day];
const formatted = value === "closed" ? "휴무" : value || "-";
const value = businessHours.weekly[dayKeyMap[day]];

const formatted = value.closed
? "휴무"
: `${value.open || "-"} - ${value.close || "-"}`;

return {
dayLabel: dayLabelMap[day],
Expand All @@ -136,6 +143,11 @@ export default function StoreInfoEditPage() {
});
}, [businessHours]);

const handleSelectAddress = (item: AddressSearchItem) => {
setInputAddress(item.roadAddress || item.lotNumberAddress || item.label);
setIsAddressSearchOpen(false);
};

const toggleRandomBoxSelection = (id: number) => {
setSelectedRandomBoxIds((prev) =>
prev.includes(id) ? prev.filter((item) => item !== id) : [...prev, id],
Expand All @@ -160,25 +172,13 @@ export default function StoreInfoEditPage() {
price: number;
buyLimit: number;
content: string;
boxId?: number;
pickupTimeInfo: {
start: string;
end: string;
};
}) => {
if (!storeId) return;

if (form.boxId) {
await updateRandomBoxMutation.mutateAsync({
storeId,
boxId: form.boxId,
body: {
boxName: form.boxName,
stock: form.stock,
price: form.price,
buyLimit: form.buyLimit,
content: form.content,
},
});
return;
}

await createRandomBoxMutation.mutateAsync({
storeId,
body: {
Expand All @@ -187,6 +187,7 @@ export default function StoreInfoEditPage() {
price: form.price,
buyLimit: form.buyLimit,
content: form.content,
pickupTimeInfo: form.pickupTimeInfo,
},
});
};
Expand Down Expand Up @@ -218,10 +219,11 @@ export default function StoreInfoEditPage() {
const storePayload: StoreUpdateReqDTO = {
storeName,
storeEmail,
bankName,
bankType: bankType || undefined,
depositor,
bankAccount,
businessHours,
tag: selectedTag ? tagMap[selectedTag] : undefined,
};

const locationPayload: StoreLocationUpdateReqDTO = {
Expand Down Expand Up @@ -256,17 +258,18 @@ export default function StoreInfoEditPage() {
<div className="pb-[3.6rem] pt-[1.6rem]">
<StoreNameField value={storeName} onChange={setStoreName} />
<EmailField value={storeEmail} onChange={setStoreEmail} />

<StoreAddressField
value={inputAddress}
onChange={setInputAddress}
onSearchAddress={() => {}}
onSearchAddress={() => setIsAddressSearchOpen(true)}
/>

<AccountField
bankName={bankName}
bankType={bankType}
depositor={depositor}
bankAccount={bankAccount}
onChangeBankName={setBankName}
onChangeBankType={(value) => setBankType(value as BankType)}
onChangeDepositor={setDepositor}
onChangeBankAccount={setBankAccount}
/>
Expand All @@ -293,7 +296,7 @@ export default function StoreInfoEditPage() {
/>

<TagSection
tagOptions={tagOptions}
tagOptions={[...tagOptions]}
selectedTag={selectedTag}
onSelectTag={setSelectedTag}
/>
Expand Down Expand Up @@ -326,6 +329,12 @@ export default function StoreInfoEditPage() {
onClose={() => setIsRandomBoxModalOpen(false)}
onSubmit={handleSubmitRandomBox}
/>

<AddressSearchBottomSheet
open={isAddressSearchOpen}
onClose={() => setIsAddressSearchOpen(false)}
onSelectAddress={handleSelectAddress}
/>
</>
);
}
68 changes: 68 additions & 0 deletions apps/owner/src/app/signup/register/_apis/searchAddressBykakao.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
"use client";

import type { AddressSearchItem } from "../_types/address-search";

export function searchAddressByKakao(
keyword: string,
size = 10,
): Promise<AddressSearchItem[]> {
return new Promise((resolve, reject) => {
const trimmedKeyword = keyword.trim();

if (!trimmedKeyword) {
resolve([]);
return;
}

if (
typeof window === "undefined" ||
!window.kakao?.maps?.services
) {
reject(new Error("Kakao services library is not loaded."));
return;
}

const geocoder = new window.kakao.maps.services.Geocoder();

geocoder.addressSearch(
trimmedKeyword,
(result: KakaoAddressSearchResult[], status: string) => {
const { kakao } = window;

if (status === kakao.maps.services.Status.ZERO_RESULT) {
resolve([]);
return;
}

if (status !== kakao.maps.services.Status.OK) {
reject(new Error("주소 검색 중 오류가 발생했습니다."));
return;
}

const mapped = result.slice(0, size).map((item, index) => {
const lotNumberAddress =
item.address?.address_name || item.address_name || "";

const roadAddress =
item.road_address?.address_name || item.address_name || "";

return {
id: `${item.x}-${item.y}-${index}`,
label: roadAddress || lotNumberAddress,
lotNumberAddress,
roadAddress,
longitude: Number(item.x),
latitude: Number(item.y),
};
});

resolve(mapped);
},
{
page: 1,
size,
analyze_type: window.kakao.maps.services.AnalyzeType.SIMILAR,
},
);
});
}
Loading
Loading