Completed Week 1 Homework - #52
Closed
HamadaNatana wants to merge 5 commits into
Closed
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
- This PR changes
Week-01-Pandas/data/joined.csvisn't recognized as a homework submission (expected something likefirstname_lastname_week_05_exercise.ipynbinside that week'sexercise/folder). - This PR changes
Week-01-Pandas/exercise/DG_Week01_HW.ipynbisn't recognized as a homework submission (expected something likefirstname_lastname_week_05_exercise.ipynbinside that week'sexercise/folder). - This PR changes
Week-01-Pandas/exercise/Exercise-DONT-EDIT-MAKE-COPY.ipynbisn't recognized as a homework submission (expected something likefirstname_lastname_week_05_exercise.ipynbinside that week'sexercise/folder).
There was a problem hiding this comment.
🟡 Changes recommended
The notebooks include a confirmed syntax error in the % private/shared print cell, and the PR also violates the repository’s homework submission rules by submitting the template notebook and using an initials-only filename.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR appears to submit a completed Week 1 Pandas homework notebook (including an exported joined.csv) for the course repository.
Changes:
- Added a completed Week 1 exercise notebook submission (
DG_Week01_HW.ipynb). - Added an exported outer-join result file (
Week-01-Pandas/data/joined.csv). - Added a filled-in copy of the template notebook under the template filename (
Exercise-DONT-EDIT-MAKE-COPY.ipynb), which conflicts with the repo’s submission instructions.
File summaries
| File | Description |
|---|---|
| Week-01-Pandas/exercise/Exercise-DONT-EDIT-MAKE-COPY.ipynb | Contains completed homework content but is the “do not edit” template filename. |
| Week-01-Pandas/exercise/DG_Week01_HW.ipynb | Completed Week 1 Pandas homework notebook submission. |
| Week-01-Pandas/data/joined.csv | CSV output produced by the notebook’s merge/export step. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 5
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+711
to
+712
| "print(f\"Private rooms: {dfp[\"Private room\"]*100:.2f}%\")\n", | ||
| "print(f\"Shared rooms: {dfp[\"Shared room\"]*100:.2f}%\")\n" |
Comment on lines
+711
to
+712
| "print(f\"Private rooms: {dfp[\"Private room\"]*100:.2f}%\")\n", | ||
| "print(f\"Shared rooms: {dfp[\"Shared room\"]*100:.2f}%\")\n" |
| @@ -0,0 +1,7 @@ | |||
| neighbourhood_group, mean_price,n_listings | |||
Comment on lines
+1
to
+3
| { | ||
| "cells": [ | ||
| { |
Comment on lines
+1
to
+3
| { | ||
| "cells": [ | ||
| { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR [adds/removes/fixes/replaces] this [feature/bug/etc].
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?