Skip to content

systemd: skip unavailable gamescope user services - #23

Open
myakupozluk wants to merge 1 commit into
CachyOS:cachyosfrom
myakupozluk:fix/skip-unavailable-user-services
Open

myakupozluk wants to merge 1 commit into
CachyOS:cachyosfrom
myakupozluk:fix/skip-unavailable-user-services

Conversation

@myakupozluk

Copy link
Copy Markdown

Summary

  • skip gamescope-xbindkeys.service unless /etc/xbindkeysrc exists
  • skip steam-notif-daemon.service unless its executable is installed

Both units are wanted by the session target, but their optional inputs are not supplied by the standard package set. Conditions let an unconfigured repo-only installation start without persistent failed user units, while preserving each service when its dependency becomes available.

Closes #22

Validation

  • systemd-analyze verify accepted both unit files; its only diagnostics are expected local absences of the optional executables
  • git diff --check

Copilot AI lite review requested due to automatic review settings September 9, 2026 14:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The added systemd ConditionPathExists= checks are correctly placed and should prevent the reported recurring user-unit failures without changing behavior when dependencies are present.

Pull request overview

This PR updates optional user systemd services in gamescope-session to avoid persistent failed units on repo-only installs by adding runtime conditions that skip the services when their required inputs aren’t present.

Changes:

  • Add a systemd condition to skip gamescope-xbindkeys.service unless /etc/xbindkeysrc exists.
  • Add a systemd condition to skip steam-notif-daemon.service unless /usr/bin/steam_notif_daemon exists.
File summaries
File Description
usr/lib/systemd/user/gamescope-xbindkeys.service Adds ConditionPathExists=/etc/xbindkeysrc so the unit cleanly skips when the config isn’t present.
usr/lib/systemd/user/steam-notif-daemon.service Adds ConditionPathExists=/usr/bin/steam_notif_daemon so the unit cleanly skips when the optional daemon isn’t installed.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gamescope-xbindkeys.service fails on every session start: /etc/xbindkeysrc is not shipped by any package

2 participants