systemd: skip unavailable gamescope user services - #23
Open
myakupozluk wants to merge 1 commit into
Open
myakupozluk wants to merge 1 commit into
myakupozluk wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The added systemd ConditionPathExists= checks are correctly placed and should prevent the reported recurring user-unit failures without changing behavior when dependencies are present.
Pull request overview
This PR updates optional user systemd services in gamescope-session to avoid persistent failed units on repo-only installs by adding runtime conditions that skip the services when their required inputs aren’t present.
Changes:
- Add a systemd condition to skip
gamescope-xbindkeys.serviceunless/etc/xbindkeysrcexists. - Add a systemd condition to skip
steam-notif-daemon.serviceunless/usr/bin/steam_notif_daemonexists.
File summaries
| File | Description |
|---|---|
| usr/lib/systemd/user/gamescope-xbindkeys.service | Adds ConditionPathExists=/etc/xbindkeysrc so the unit cleanly skips when the config isn’t present. |
| usr/lib/systemd/user/steam-notif-daemon.service | Adds ConditionPathExists=/usr/bin/steam_notif_daemon so the unit cleanly skips when the optional daemon isn’t installed. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gamescope-xbindkeys.serviceunless/etc/xbindkeysrcexistssteam-notif-daemon.serviceunless its executable is installedBoth units are wanted by the session target, but their optional inputs are not supplied by the standard package set. Conditions let an unconfigured repo-only installation start without persistent failed user units, while preserving each service when its dependency becomes available.
Closes #22
Validation
systemd-analyze verifyaccepted both unit files; its only diagnostics are expected local absences of the optional executablesgit diff --check