fix(cli): CliUserError for missing notifyAppReady / public key / appId

[riderx]

Summary (AI generated)

• Convert expected CLI configuration failures to CliUserError so shouldCapturePosthogException skips them instead of opening PostHog $exception issues.
• notifyAppReady() is missing in build folder — bundle zip (zip.ts).
• Missing public key in config — bundle encrypt (encrypt.ts).
• Missing appId — bundle, channel, app, preview, and build commands throw CliUserError('Missing appId').
• Rebased onto latest main @ 12.257.2 (dcd9561b); merged with fix(cli): treat existing channel as success on channel add #3195 channel-add duplicate recovery and fix(cli): throw CliUserError for capacitor config and org lookup #3182 config/org CliUserError tests.

Motivation (AI generated)

PostHog error tracking classified legitimate user setup mistakes as unhandled crashes (~79 / ~28 / ~16 users), creating triage noise for notifyAppReady, missing public key, and missing appId.

Business Impact (AI generated)

• Reduces false-positive error tracking volume so real CLI regressions surface faster.
• No change to user-facing exit codes, printed guidance, or trackCommandFailed analytics.

Test Plan (AI generated)

• cd cli && bun run test:cli-user-error-config
• cd cli && bun run test:posthog-exception
• CI green — Run tests #32846624510 (pull_request)
• Rebased onto latest main; no merge conflicts
• 0 unresolved review threads; reviewDecision APPROVED; mergeStateStatus CLEAN

Generated with AI

  

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{On-demand reviews are free for the next 26 days. After that, they cost $0.25 per reviewed file.}

Or wait 31 minutes for your next included review.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 55 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5d20277a-b884-4bd0-9f7c-945b6e058780

📥 Commits

Reviewing files that changed from the base of the PR and between dcd9561 and daf07db.

📒 Files selected for processing (20)

• cli/package.json
• cli/src/app/debug.ts
• cli/src/app/delete.ts
• cli/src/app/set.ts
• cli/src/build/needed.ts
• cli/src/build/prescan/context.ts
• cli/src/bundle/cleanup.ts
• cli/src/bundle/compatibility.ts
• cli/src/bundle/delete.ts
• cli/src/bundle/encrypt.ts
• cli/src/bundle/list.ts
• cli/src/bundle/unlink.ts
• cli/src/bundle/zip.ts
• cli/src/channel/add.ts
• cli/src/channel/delete.ts
• cli/src/channel/list.ts
• cli/src/channel/set.ts
• cli/src/preview/qr.ts
• cli/test/test-cli-user-error-config.mjs
• cli/test/test-posthog-exception.mjs

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands.}

[TorichanCapgo]

Closing: Martin’s direction is not to silence these as CliUserError / skip PostHog capture. Keep tracking real user failures and fix success paths (auto-detect, prompt to create/fix, inject missing pieces) so users complete the flow. Will reopen as success-path PRs where we have a clear product fix.

[TorichanCapgo]

Do not merge — Martin rejected CliUserError-only silencing. Keep PostHog tracking for these user failures; prefer success-path fixes (auto-detect / prompt / inject) so users complete the flow. Replacement work in flight for notifyAppReady/public key/appId; same direction for the rest of this batch (#3175–#3182 CliUserError PRs).

[cursor]

Do not merge this PR.

Martin rejected the CliUserError / shouldCapturePosthogException silencing approach for these expected-config failures. We should keep tracking them in PostHog and instead fix the success path so users can complete the flow:

• auto-detect appId
• generate + write public key when missing
• inject / fix notifyAppReady

A separate cloud agent (bc-99b4ff8e…) is handling the rewrite. This PR should be closed or abandoned — not merged.

[codspeed-hq]

Merging this PR will not alter performance

✅ 43 untouched benchmarks
⏩ 2 skipped benchmarks¹

---

_{Comparing cursor/cli-user-error-config-failures-b5f7 (daf07db) with main (dcd9561)}

Footnotes

1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[cubic-dev-ai]

All reported issues were addressed

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cursor]

@coderabbitai review

[cursor]

@coderabbitai review

[cursor]

@coderabbitai full review

[cursor]

@coderabbitai review

[TorichanCapgo]

Rebased onto main (12.257.1). Conflicts resolved. CI green on run 32841965137. All review threads addressed.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cursor]

@coderabbitai review