Prop types fix#723
Open
alasarr wants to merge 1 commit intoairship-3.0from
Open
Conversation
neokore
reviewed
Nov 4, 2020
| PropTypes.shape({ | ||
| category: PropTypes.string.isRequired, | ||
| value: PropTypes.number.isRequired | ||
| value: PropTypes.number |
Contributor
There was a problem hiding this comment.
Here we can use oneOfType and allow number/string/null
After checking the docs again, I see that this is the recommended way for null (plus undefined and so)
I agree with the change.
neokore
reviewed
Nov 4, 2020
| ]).isRequired, | ||
| unit: PropTypes.string.isRequired | ||
| ]), | ||
| unit: PropTypes.string |
Contributor
There was a problem hiding this comment.
same here, until we want to allow empty units using this format, in that case, ok
Maybe here I'll rather improve the way to paint the unit, to skip it in case of not existing, because right now it could leave an empty space before the value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.