Move InternalsVisibleTo attribute to project file#210
Merged
Conversation
Copilot
AI
changed the title
Move InternalsVisibleTo to csproj
Move InternalsVisibleTo attribute to project file
Jun 29, 2026
Copilot created this pull request from a session on behalf of
304NotModified
June 29, 2026 22:18
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves the InternalsVisibleTo assembly-level attribute out of a source file and into the SDK-style project file, aligning visibility configuration with project configuration for easier maintenance and clearer ownership.
Changes:
- Added an
<InternalsVisibleTo ... />item insrc/UTF-unknown.csprojforUtfUnknown.Tests(with the strong-name public key). - Removed the
[assembly: InternalsVisibleTo(...)]attribute fromsrc/DetectionDetail.cs. - Removed the now-unused
System.Runtime.CompilerServicesusing directive fromsrc/DetectionDetail.cs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/UTF-unknown.csproj | Adds InternalsVisibleTo as a project item so the SDK generates the assembly attribute during build. |
| src/DetectionDetail.cs | Removes the embedded assembly attribute and the unused System.Runtime.CompilerServices using. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assembly-level attributes that control visibility should be declared in the project configuration rather than embedded in source files for better maintainability and clarity.
Changes:
InternalsVisibleToattribute fromsrc/DetectionDetail.cstosrc/UTF-unknown.csprojSystem.Runtime.CompilerServicesusing directiveBefore:
After: