Add DetectFromBytes(ReadOnlySpan<byte>) overload with comprehensive tests#211
Draft
304NotModified with Copilot wants to merge 7 commits into
Draft
Add DetectFromBytes(ReadOnlySpan<byte>) overload with comprehensive tests#211304NotModified with Copilot wants to merge 7 commits into
304NotModified with Copilot wants to merge 7 commits into
Conversation
Copilot created this pull request from a session on behalf of
304NotModified
July 3, 2026 21:34
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies PR #204 changes to add a
ReadOnlySpan<byte>overload forDetectFromBytes, allowing callers to detect encoding from a span or slice without copying to abyte[]. Also addresses review feedback and bugs found during integration.Source changes
CharsetDetector.DetectFromBytes(ReadOnlySpan<byte>)— existingbyte[]overloads now delegate to itFeed,HandleData,FindInputState,IsStartsWithBom,FindCharSetByBom,RunProber, all probers, and analyzers updated to acceptReadOnlySpan<byte>instead ofbyte[]+ offset/lenWriteSpanToStreamcompile guard: changed fromNETSTANDARD2_1_OR_GREATER || NETCOREAPP2_1_OR_GREATER→NET8_0_OR_GREATERper review comment (targets are netstandard2.0 and net8.0)JapaneseContextAnalyser.HandleData: removed staleoffset/lenparameters, now span-only for consistencyFeed()whenbuf.Length == 0; several probers (e.g.EUCKRProber,SJISProber) unconditionally accessbuf[max - 1]and would throwIndexOutOfRangeExceptionon empty inputTests
Added 16 new tests covering the
ReadOnlySpan<byte>overload:Covers: empty span, ASCII, UTF-8 (with and without BOM), sliced span, UTF-7/GB18030/UTF-16 BE+LE/UTF-32 BE+LE BOM detection.