fix(core): make autoUpdateConversationModel work without rule - #1020
Closed
dingyi222666 wants to merge 1 commit into
Closed
dingyi222666 wants to merge 1 commit into
dingyi222666 wants to merge 1 commit into
Conversation
The trigger condition required resolved.constraint.autoUpdateModel === true, but autoUpdateModel defaulted to undefined when no rule was configured, so the global autoUpdateConversationModel switch never took effect. Default it to true so the global switch works; rule autoUpdateModel/fixedModel can still opt out per-route. Closes #1012
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Walkthrough
Changes会话模型约束
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
关闭此 PR,修复直接合入 #1015 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1012
Root cause: the auto-update trigger in
resolve_conversationrequiredresolved.constraint.autoUpdateModel === true, butresolveConstraintdefaulted
autoUpdateModeltoundefinedwhen no rule was configured for theroute. So
undefined === truewas always false and the globalautoUpdateConversationModelswitch never took effect.Fix: default
autoUpdateModeltotrueinresolveConstraintwhen no rulesets it. The global switch now works as documented; per-route opt-out is still
possible via rule
autoUpdateModel: falseorfixedModel.