fix(adapters): filter empty text parts in message conversion - #1024
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
WalkthroughChanges空文本过滤
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
多模态消息转换时,空文本 part(如
{type:'text', text:''})会被原样透传到模型请求中,例如 Gemini 请求里出现{"text":""}空 text part,可能导致部分 API 报错。空 text part 的来源包括:
fileInsertPrompt未配置(默认空字符串)时read_files注入的多模态消息、content 为空字符串的消息等。修复
在适配器消息转换层统一过滤空文本 part(最小判断
length > 0):langchainMessageToOpenAIMessage): 数组 content 中空 text part 丢弃 —— 覆盖所有 OpenAI 兼容适配器(openai / openai-like / azure-openai / deepseek / qwen / doubao / rwkv / hunyuan / spark / wenxin / zhipu)processGeminiContentParts+langchainMessageToGeminiMessage): 空 text part 丢弃;字符串 content 为空时不生成[{text:''}]processMessageContent): 空 text block 丢弃ollama / dify 走字符串/文本提取路径,无空 part 结构问题,无需修改。
Validation