fix(adapters): mark deepseek-flash and glm-5.3-flash as vision models - #1038
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Walkthrough本次变更新增 Changes模型支持更新
Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 小兔登记新模型, Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
supportImageInput()inshared-adapterdecides image capability by model name.deepseek-flashsupports image input but was not matched (the check introduced in #1029 only matches thevisionkeyword), andglm-5.3-flashwas missing entirely.Changes
deepseek-flashandglm-5.3-flashto the image model matchers inpackages/shared-adapter/src/client.ts.GLM-5.3-Flash(1M context) to the model list inpackages/adapter-zhipu/src/client.ts.The matchers stay narrow: text-only variants such as
deepseek-v4-flash,GLM-4-FlashandGLM-4.5-Flashare not affected.Verification
yarn fast-build shared-adapteryarn fast-build adapter-zhiputsc --noEmit -p packages/shared-adapter/tsconfig.jsontsc --noEmit -p packages/adapter-zhipu/tsconfig.json