Skip to content

fix(adapters): mark deepseek-flash and glm-5.3-flash as vision models - #1038

Merged
dingyi222666 merged 1 commit into
v1-devfrom
fix/deepseek-glm-flash-vision
Sep 12, 2026
Merged

dingyi222666 merged 1 commit into
v1-devfrom
fix/deepseek-glm-flash-vision

Conversation

@dingyi222666

Copy link
Copy Markdown
Member

Problem

supportImageInput() in shared-adapter decides image capability by model name. deepseek-flash supports image input but was not matched (the check introduced in #1029 only matches the vision keyword), and glm-5.3-flash was missing entirely.

Changes

  • Add deepseek-flash and glm-5.3-flash to the image model matchers in packages/shared-adapter/src/client.ts.
  • Add GLM-5.3-Flash (1M context) to the model list in packages/adapter-zhipu/src/client.ts.

The matchers stay narrow: text-only variants such as deepseek-v4-flash, GLM-4-Flash and GLM-4.5-Flash are not affected.

Verification

  • yarn fast-build shared-adapter
  • yarn fast-build adapter-zhipu
  • tsc --noEmit -p packages/shared-adapter/tsconfig.json
  • tsc --noEmit -p packages/adapter-zhipu/tsconfig.json

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 668faa9e-a5b4-4b20-8558-5f94f71cc406

📥 Commits

Reviewing files that changed from the base of the PR and between 6ee104f and 5cc4525.

📒 Files selected for processing (2)
  • packages/adapter-zhipu/src/client.ts
  • packages/shared-adapter/src/client.ts

Walkthrough

本次变更新增 GLM-5.3-Flash 模型及其 1_000_000maxTokens,并扩展图像模型匹配规则。

Changes

模型支持更新

Layer / File(s) Summary
模型注册与图像匹配
packages/adapter-zhipu/src/client.ts, packages/shared-adapter/src/client.ts
refreshModels() 新增 GLM-5.3-Flash。图像模型匹配列表新增 ocrdeepseek-flashglm-5.3-flash

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/deepseek-glm-flash-vision

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

小兔登记新模型,
Flash 轻快入清单。
百万令牌已准备,
图像匹配添新名,
耳朵摇摇庆更新。

Comment @coderabbitai help to get the list of available commands.

@dingyi222666
dingyi222666 merged commit 756dabd into v1-dev Sep 12, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant