Skip to content

fix/feat: named channels and interrupts - #584

Merged
mhier merged 1 commit into
masterfrom
mhier/fix-interrupts-and-named-channels
Sep 8, 2026
Merged

mhier merged 1 commit into
masterfrom
mhier/fix-interrupts-and-named-channels

Conversation

@mhier

@mhier mhier commented Sep 8, 2026

Copy link
Copy Markdown
Member

No description provided.

@mhier
mhier requested a review from phako September 8, 2026 13:09

@phako phako left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused, so we did NOT support interrupted named channels, but were also missing the tests for what we supported?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The behavior change is narrowly scoped, consistent with existing access-mode semantics, and is covered by updated and new tests.

Pull request overview

This PR updates the JSON map parsing behavior so that named channel slices of interrupt-driven 2D registers inherit interrupt semantics (and thus support wait_for_new_data), while slices of non-interrupt 2D registers remain read-only and do not advertise wait_for_new_data.

Changes:

  • Update JsonMapFileParser to mark named channel slices as INTERRUPT when their parent 2D register is interrupt-driven.
  • Extend JSON map parser tests to assert correct access mode flags for interrupt vs non-interrupt named slices.
  • Add a new non-interrupt 2D register with named channels to the test JSON map file to validate read-only slice behavior.
File summaries
File Description
tests/simpleJsonFile.jmap Adds a non-interrupt 2D register with named channels (SIMPLE2D) to exercise slice behavior.
tests/executables_src/testNumericAddressedBackendUnified.cpp Adds an async named-slice unified-backend test for an interrupt-driven 2D register slice.
tests/executables_src/testJsonMapFileParser.cpp Updates expectations: interrupt-driven 2D slices now advertise wait_for_new_data; adds coverage for non-interrupt 2D slice behavior.
src/JsonMapFileParser.cc Implements access-mode propagation for named channel slices of interrupt-driven 2D registers.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@mhier
mhier merged commit 670f569 into master Sep 8, 2026
1 check passed
@mhier
mhier deleted the mhier/fix-interrupts-and-named-channels branch September 8, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants