Replace the FOSS dot with a corner badge on app entries - #4924
Conversation
- Add New-WinUtilFossBadge, the open source keyhole on a green backdrop - Mark FOSS apps with a corner triangle instead of a dot after the name - Give the FOSS legend a circle badge and move it below the buttons - Sort Note entries last, they shared a rank with checkboxes before Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR adds a reusable WPF FOSS badge, replaces inline FOSS markers in notes and application entries, updates note sorting, and changes install-entry checkbox handling for the nested Grid layout. ChangesFOSS badge and application entry UI
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant InvokeWPFUIElements
participant NewWinUtilFossBadge
participant WPFNote
InvokeWPFUIElements->>NewWinUtilFossBadge: Create rounded FOSS badge
NewWinUtilFossBadge->>WPFNote: Return badge element
InvokeWPFUIElements->>WPFNote: Render badge before note text
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@functions/private/Initialize-InstallAppEntry.ps1`:
- Around line 25-26: Use consistent variable casing in the checkbox toggle
logic: update the assignment target in Initialize-InstallAppEntry to use the
existing $childCheckbox variable defined immediately above, replacing the
mismatched $childCheckBox reference.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e05b53fb-5ff4-4502-839c-f9605e0ca185
📒 Files selected for processing (3)
functions/private/Initialize-InstallAppEntry.ps1functions/private/New-WinUtilFossBadge.ps1functions/public/Invoke-WPFUIElements.ps1
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
This is really cool |
mewclouds
left a comment
There was a problem hiding this comment.
Oh yeah, this looks great. Loving the changes to the UI 😍
Type of Change
Description
This changes how FOSS applications are marked on the Install tab. Previously a small green dot was appended to the application name, which was not very clear to be such kind of indication on first sight
FOSS applications now carry a green triangle in the top right corner of their entry, with a keyhole on it. The badge is drawn as vector paths in a
Viewbox, meaning scalable.Since there is not really a standardized logo for "FOSS" and to avoid missunderstandings i refrained from using official logos like the one of the Open Source Initiative ® and tried to do something similar for recognitial purposes.
The legend in the left panel uses the same badge as a circle. The legend also moved below the buttons. It was rendered above them because entries are sorted by type rank and
Noteshared rank 0 with checkboxes; notes now sort last. TheOrderfield inappnavigation.jsonis not read by the renderer, so no config change was needed.Every app entry now wraps its checkbox in a layout
Gridrather than only the FOSS ones, so the checkbox handlers reach the border the same way for every entry. This does not changeapplications.jsonor thefossflag it carries.Comparison
Verification
Verified with:
Issue related to PR
N/A