Skip to content

Fix screen reader button accessibility and category navigation - #4944

Merged
ChrisTitusTech merged 3 commits into
ChrisTitusTech:mainfrom
makhlwf:accessibilityroolsfix
Aug 9, 2026
Merged

Fix screen reader button accessibility and category navigation#4944
ChrisTitusTech merged 3 commits into
ChrisTitusTech:mainfrom
makhlwf:accessibilityroolsfix

Conversation

@makhlwf

@makhlwf makhlwf commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Type of Change

  • Bug fix
  • UI/UX improvement

Description

This PR addresses screen reader navigation issues across dynamically generated panels and top-bar controls:

  1. Native Control Peers: Replaced ItemsControl with ScrollViewer + StackPanel in Invoke-WPFUIElements. WPF's ItemsControlAutomationPeer automatically wrapped child controls in a DataItemAutomationPeer, causing screen readers (NVDA, Narrator) to announce normal buttons as position-indexed DATAITEM entries. Exposing controls via StackPanel inside a ScrollViewer restores native Button, CheckBox, and RadioButton control peers while maintaining vertical scrolling.
  2. Category Header Navigation: Enabled keyboard tab focus on category header labels (Focusable = $true, IsTabStop = $true) so screen reader users hear category section titles when tabbing through tweak panels.
  3. Settings Button Accessibility: Added AutomationProperties.Name="Settings" and tooltip to SettingsButton in inputXML.xaml so the gear icon button is properly announced rather than reading raw Unicode \ue713.
  4. Search Filter Compatibility: Updated Find-TweaksByNameOrDescription to handle ScrollViewer and StackPanel containers safely.

Issue related to PR

  • Resolves #

@makhlwf
makhlwf requested a review from ChrisTitusTech as a code owner August 7, 2026 20:23
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@github-actions github-actions Bot added bug Something isn't working ui update UI/UX improvements labels Aug 7, 2026
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d38da27-1441-4d0b-b33f-5be3a11ab6b9

📥 Commits

Reviewing files that changed from the base of the PR and between 8d3adb5 and a1d28ce.

📒 Files selected for processing (3)
  • functions/private/Find-TweaksByNameOrDescription.ps1
  • functions/public/Invoke-WPFUIElements.ps1
  • xaml/inputXML.xaml

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Improved compatibility when displaying and filtering tweak categories across supported UI layouts.
    • Added smoother scrolling for panels containing settings and controls.
    • Enhanced keyboard navigation and accessibility information for category labels.
    • Added a tooltip and accessibility name to the Settings button.

Walkthrough

The WPF UI generator now uses a scrollable StackPanel for generated controls and adds accessibility metadata. Tweak filtering supports Items, Children, and runtime type-name checks across supported container variants.

Changes

UI and search compatibility

Layer / File(s) Summary
Scrollable UI container and accessibility
functions/public/Invoke-WPFUIElements.ps1, xaml/inputXML.xaml
The UI generator places categories and generated controls in a stretch-aligned ScrollViewer and StackPanel. Category labels and the Settings button receive accessibility properties.
Generalized tweak container filtering
functions/private/Find-TweaksByNameOrDescription.ps1
Tweak filtering resolves Items or Children collections and recognizes supported controls by concrete type or runtime type name.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: christitustech

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main accessibility and category navigation changes.
Description check ✅ Passed The description directly explains the screen reader, focus, settings button, and container changes in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@makhlwf

makhlwf commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

I had a time issue on my system, so this could explain the weird commit timing.

@ChrisTitusTech

Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a1d28ce80b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread functions/public/Invoke-WPFUIElements.ps1 Outdated
Inspect targetGrid and its parent hierarchy in Invoke-WPFUIElements to avoid adding an inner ScrollViewer when an outer ScrollViewer already exists.
@makhlwf

makhlwf commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

I would like a review from you

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: ea0362ed35

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ChrisTitusTech
ChrisTitusTech merged commit afc3e1e into ChrisTitusTech:main Aug 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ui update UI/UX improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants