Fix screen reader button accessibility and category navigation - #4944
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe WPF UI generator now uses a scrollable ChangesUI and search compatibility
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I had a time issue on my system, so this could explain the weird commit timing. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1d28ce80b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Inspect targetGrid and its parent hierarchy in Invoke-WPFUIElements to avoid adding an inner ScrollViewer when an outer ScrollViewer already exists.
I would like a review from you |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Type of Change
Description
This PR addresses screen reader navigation issues across dynamically generated panels and top-bar controls:
ItemsControlwithScrollViewer+StackPanelinInvoke-WPFUIElements. WPF'sItemsControlAutomationPeerautomatically wrapped child controls in aDataItemAutomationPeer, causing screen readers (NVDA, Narrator) to announce normal buttons as position-indexedDATAITEMentries. Exposing controls viaStackPanelinside aScrollViewerrestores nativeButton,CheckBox, andRadioButtoncontrol peers while maintaining vertical scrolling.Focusable = $true,IsTabStop = $true) so screen reader users hear category section titles when tabbing through tweak panels.AutomationProperties.Name="Settings"and tooltip toSettingsButtonininputXML.xamlso the gear icon button is properly announced rather than reading raw Unicode\ue713.Find-TweaksByNameOrDescriptionto handleScrollViewerandStackPanelcontainers safely.Issue related to PR