Skip to content

Increase Advisor plan-review limit to eight - #20

Open
revotech-claude wants to merge 1 commit into
Cjbuilds:mainfrom
revotech-claude:codex/advisor-review-rounds-8
Open

revotech-claude wants to merge 1 commit into
Cjbuilds:mainfrom
revotech-claude:codex/advisor-review-rounds-8

Conversation

@revotech-claude

@revotech-claude revotech-claude commented Jul 19, 2026

Copy link
Copy Markdown

Summary

  • raise the Advisor plan-review safety cap from five to eight
  • keep compact ledgers through rounds two to eight
  • fail closed on a round-eight PLAN_REVISE
  • update generated-policy assertions and public documentation

Verification

  • python3 -m compileall -q plugins tests scripts
  • python3 -m ruff check plugins tests scripts
  • python3 -m unittest discover -s tests -v (343 passed, 5 skipped)
  • python3 tests/plugin_lifecycle_smoke.py
  • branch-wide local autoreview, gpt-5.6-sol High: clean
  • Fable implementation review: IMPLEMENTATION_APPROVED

Fixes #19

{
"schema": 1,
"risk_tier": "security-state",
"repository": "Cjbuilds/Codex-Orchestration",
"base_branch": "main",
"reviewed_head_sha": "50af1760f6260f79e2432d214dd7218da6729e51",
"reviewer_identity": "gpt-5.6-sol",
"reviewer_route": "local autoreview at High plus Fable implementation review at medium",
"threat_model": {
"assets": ["Fail-closed Advisor approval loop and bounded review-cost policy"],
"threats": ["Inconsistent limits could execute an unapproved plan or create an unbounded review loop"],
"mitigations": ["Exact contract assertions bind documentation and generated policy to eight rounds and a round-eight halt"]
},
"negative_test_evidence": [
{"category": "regression", "evidence": "343 unit tests passed after rebasing onto the exact PR base"},
{"category": "negative", "evidence": "Exact assertions require round-eight PLAN_REVISE to halt before Executor release"},
{"category": "malformed", "evidence": "Existing stale-version and invalid-ledger fail-closed contract tests remain passing"}
],
"findings_disposition": "No accepted or actionable findings remained after exact-head branch autoreview; Fable returned IMPLEMENTATION_APPROVED"
}

@Cjbuilds

Copy link
Copy Markdown
Owner

Do not merge this branch in its current form. It is stale and has been superseded by #32, which implemented issue #19 on the current release line and was independently verified and merged.

Why #20 is no longer safe to merge:

  • its base is d7d2150776376a3186f0f452d3b119b1f7363ff7, far behind current main;
  • it targets the old 0.7.2-era payload and does not carry the current synchronized release identity;
  • its review attestation and checks apply only to stale head 50af1760f6260f79e2432d214dd7218da6729e51, not to a current-main integration;
  • Raise Advisor review limit to eight #32 adds the authoritative ADVISOR_REVIEW_LIMIT = 8, causal regression coverage, stale-cap sweeps, release metadata alignment at 0.9.3, independent verification, exact-head protected checks, and clean post-merge CI/CodeQL.

Issue #19 is now closed by #32. Leaving this PR open for the author/maintainer to decide whether to close it; it should not be rebased or merged without a fresh full review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase Advisor plan-review cap from five to eight

2 participants