Conversation
Vri6500
marked this pull request as ready for review
July 26, 2026 18:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
tool_timeout_secto 660 seconds on all three bundled Claude MCP launchersWhy
Claude Opus 5 XHigh reviews can take longer than Codex's default 300-second MCP tool timeout. The bridge itself already allows 600 seconds, so Codex could cancel a healthy review before the bridge returned either its schema-validated result or its own fail-closed timeout error.
The new contract is
660s Codex tool timeout > 600s Claude subprocess timeout. This preserves the selected XHigh effort and all existing authentication, model-identity, structured-output, and fail-closed validation.Impact
Long-running bundled Claude Planner or Advisor calls can now use the bridge's complete bounded runtime. Fast calls are unaffected. Calls that exceed 600 seconds still fail closed inside the bridge.
Validation
python3 -m unittest -v tests.test_packaging tests.test_release_check— 38 passedpython3 scripts/preflight.py quick— available local gates passedpython3 scripts/preflight.py full— full tests and disposable plugin install/upgrade lifecycle passedpython3 -m json.toolRuff was not installed locally. The hosted Ruff check passed.
Review attestation
{
"schema": 1,
"risk_tier": "security-state",
"repository": "Cjbuilds/Codex-Orchestration",
"base_branch": "main",
"reviewed_head_sha": "33fa720392abf01d7ba455449b93f68194f0626f",
"reviewer_identity": "Codex Executor final-tree reviewer at the exact head commit",
"reviewer_route": "gpt-5.6-sol xhigh read-only Executor route",
"threat_model": {
"assets": [
"Schema-validated Advisor decisions and selected model identity",
"Prompt and provider-output confidentiality during timeout failure",
"Bounded availability of the bundled Claude MCP launchers",
"Consistent plugin release identity across packaged surfaces"
],
"threats": [
"Codex cancels a healthy review before the bridge returns",
"A Claude subprocess hangs beyond the intended bounded runtime",
"Malformed or unconfirmed model output is treated as approval",
"Only one bundled Python launcher receives the timeout setting",
"Payload changes ship without a consistent semantic version bump"
],
"mitigations": [
"Set every bundled launcher to a 660-second outer tool timeout",
"Keep the Claude subprocess bounded at 600 seconds and authentication at 20 seconds",
"Retain fail-closed schema and runtime-model validation with output withholding",
"Keep all bundled launchers disabled until the user selects the route",
"Assert timeout ordering and release identity through packaging and lifecycle tests"
]
},
"negative_test_evidence": [
{
"category": "regression",
"evidence": "Exact-head packaging tests require all three launchers to use 660 seconds and exceed the bounded 600-second bridge timeout."
},
{
"category": "negative",
"evidence": "Exact-head timeout and unexpected-argument tests passed, confirming failures remain bounded, fail closed, and do not leak prompt or provider output."
},
{
"category": "malformed",
"evidence": "Exact-head tests passed for malformed JSON, unconfirmed model identity, malformed semantic versions, and invalid review output."
}
],
"findings_disposition": "No actionable findings; the exact final tree was approved after security, compatibility, packaging, timeout, and fail-closed review."
}