Added Steam Controller support - #528
Conversation
- Allow emulating Xbox or PS5 controllers, both with their own advantages and disadvantages - Added support for gyroscope, battery and LED - Implemented rumble - Properly reset the controller when stopping to stream
|
Thank you! At first glance it doesn't look like very much AI generated which is great, even though this PR touches so many files. I'll do a detailed review when I get some time. |
| // final HIDDeviceManager finalThis = this; | ||
| // mHandler.postDelayed(new Runnable() { | ||
| // @Override | ||
| // public void run() { | ||
| // finalThis.chromebookConnectionHandler(); | ||
| // } | ||
| // }, 5000); |
There was a problem hiding this comment.
keep unused code or remove before merge?
There was a problem hiding this comment.
Most of the class is a direct copy of SDL2's implementation: https://github.com/libsdl-org/SDL/blob/main/android-project/app/src/main/java/org/libsdl/app/HIDDeviceManager.java
That code is commented-out already in the source. My reasoning was that for probable future changes it might be nice to be able to recognize as much of the original source as possible to find deviations. But I can also see that dead code doesn't look nice.
| } | ||
|
|
||
| private void initializeBluetooth() { | ||
| //Log.d(TAG, "Initializing Bluetooth"); |
There was a problem hiding this comment.
keep unused code or remove before merge?
There was a problem hiding this comment.
That line is actually not commented-out in the source (see below), but I wanted to avoid spamming the log during debugging. That's actually why the SteamController class also has a lot of these log lines ready to be uncommented if someone has to debug a problem.
I'm indifferent about removing those lines if they don't fit the style of the project, however.
|
@pschaub Sorry for being unresponsive, I'll try uploading another patch set on the weekend. I've also fixed some performance issues in the meantime. |
3 participants
Improved upon the Steam Controller support for the original Moonlight Android client by @JnCrMx for issue moonlight-stream#1062
I've made a pull request for this fork instead of for the original repo because I see a higher chance that the pull request is recognized.
A short summary of what the pull request does:
Fixes #263