Add configurable rumble rate limiting - #587
Open
KillianG wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
An XGIMI XR13A running Android 14 reproducibly restarts its Android framework during Artemis sessions with a DualSense controller. The native tombstone shows
system_serveraborting in the input stack:Immediately before the crash, Artemis logs a dense burst of rumble updates. Disabling Apollo's
forward_rumbleoption prevents the restart, but removes vibration entirely. This setting provides a client-side compatibility workaround without disabling rumble.The default is 0 ms, preserving existing behavior. Stop commands bypass the limiter to avoid stuck vibration.
Testing
ANDROID_HOME=/usr/lib/android-sdk ./gradlew :app:compileNonRoot_gameDebugJavaWithJavacANDROID_HOME=/usr/lib/android-sdk ./gradlew :app:testNonRoot_gameDebugUnitTest --tests com.limelight.binding.input.RumbleRateLimiterTest --tests com.limelight.preferences.PreferenceConfigurationTestThe focused tests cover disabled behavior, latest-value coalescing, immediate stops, controller cancellation, and preference loading. The complete existing unit suite was also run; it retains five unrelated baseline failures in layout/startup/profile navigation tests.