Skip to content

fix(ProgressBar): light theme text color#1145

Merged
gjones merged 7 commits into
mainfrom
fix-progress-bar-light-color
Jul 8, 2026
Merged

fix(ProgressBar): light theme text color#1145
gjones merged 7 commits into
mainfrom
fix-progress-bar-light-color

Conversation

@ricardoasmarques

Copy link
Copy Markdown
Contributor

Why?

ProgressBar text color in light mode is very similar to the background color, making it very hard to read.

Before
image
image

After
image
image

How?

Progress bar relies on mix-blend-mode: difference which works better on high-contrast colors, so I've created a new --click-progressBar-color-text-default token and populated it with the following colors:

  • Light: white
  • Dark: same color that was already being used before

Contribution checklist?

  • You've done enough research before writing
  • You have reviewed the PR
  • The commit messages are detailed
  • The build command runs locally
  • Assets or static content are linked and stored in the project
  • For documentation, guides or references, you've tested the commands

Security checklist?

  • All user inputs are validated and sanitized
  • No usage of dangerouslySetInnerHTML
  • Sensitive data has been identified and is being protected properly
  • Build output contains no secrets or API keys

@changeset-bot

changeset-bot Bot commented Jul 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 44873fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clickhouse/click-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant

CLAassistant commented Jul 6, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ricardoasmarques ricardoasmarques marked this pull request as draft July 6, 2026 23:02
@ricardoasmarques ricardoasmarques force-pushed the fix-progress-bar-light-color branch from a6afd1b to 05aebdd Compare July 7, 2026 09:27
@ricardoasmarques ricardoasmarques marked this pull request as ready for review July 7, 2026 09:54
@vineethasok

Copy link
Copy Markdown
Collaborator

@gjones Is these tokens available in figma and we might need to correct it there and sync it

@DreaminDani DreaminDani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. even works when it's cutting through the text 😎

Image Image

Tagging @gjones as a reviewer since he has to update the figma tokens manually. I'd love to get him out of being the bottleneck for this but we can do that later 😓

@ricardoasmarques ricardoasmarques force-pushed the fix-progress-bar-light-color branch from 70f0922 to 5805f38 Compare July 8, 2026 14:55
Comment thread tokens/themes/light.json Outdated
Comment thread tokens/themes/dark.json Outdated
@workflow-authentication-public

Copy link
Copy Markdown
Contributor

Storybook Preview Deployed

✅ Preview URL: https://click-aeylusbj5-clickhouse.vercel.app

Built from commit: a1816b9b810911d4a08c366affe2edac7be55e46

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 44873fa. Configure here.

Comment thread src/components/ProgressBar/ProgressBar.module.css
@gjones gjones merged commit 7476634 into main Jul 8, 2026
9 checks passed
@gjones gjones deleted the fix-progress-bar-light-color branch July 8, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants