fix(ProgressBar): light theme text color#1145
Conversation
🦋 Changeset detectedLatest commit: 44873fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
a6afd1b to
05aebdd
Compare
|
@gjones Is these tokens available in figma and we might need to correct it there and sync it |
DreaminDani
left a comment
There was a problem hiding this comment.
Nice. even works when it's cutting through the text 😎
Tagging @gjones as a reviewer since he has to update the figma tokens manually. I'd love to get him out of being the bottleneck for this but we can do that later 😓
70f0922 to
5805f38
Compare
Storybook Preview Deployed✅ Preview URL: https://click-aeylusbj5-clickhouse.vercel.app Built from commit: |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 44873fa. Configure here.

Why?
ProgressBar text color in light mode is very similar to the background color, making it very hard to read.
Before


After


How?
Progress bar relies on
mix-blend-mode: differencewhich works better on high-contrast colors, so I've created a new--click-progressBar-color-text-defaulttoken and populated it with the following colors:Contribution checklist?
buildcommand runs locallySecurity checklist?
dangerouslySetInnerHTML