feat(controller): allow configurable listen_host in network config#258
Open
arekborucki wants to merge 2 commits into
Open
feat(controller): allow configurable listen_host in network config#258arekborucki wants to merge 2 commits into
arekborucki wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Some Kubernetes clusters run IPv4-only, IPv6-only, or dual-stack networking, and need ClickHouse to listen only on the addresses their environment allows. Today listen_host is hardcoded to ["::", "0.0.0.0"] in the operator's network template, so the only workaround is a non-obvious settings.extraConfig merge with
@remove. This exposes it as a clean, first-class API.What
Added spec.settings.network.listenHost []string to ClickHouseSettings. The value is rendered into the server's listen_host config; when unset or empty it falls back to the previous default ["::", "0.0.0.0"], so existing clusters are unaffected. Includes regenerated CRD/deepcopy/API-reference/helm-chart and unit tests for both the default and an override case.
Related Issues
Fixes #217