Skip to content

fix: allow cluster profiles without database engine - #697

Merged
koletzilla merged 1 commit into
ClickHouse:mainfrom
fallintoplace:fix/cluster-without-database-engine
Aug 3, 2026
Merged

fix: allow cluster profiles without database engine#697
koletzilla merged 1 commit into
ClickHouse:mainfrom
fallintoplace:fix/cluster-without-database-engine

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

Summary

  • normalize an omitted database_engine before evaluating cluster support
  • add parameterized coverage for empty, standard, and replicated database engines

Details

database_engine is optional in profile credentials. When a cluster was configured without it, the adapter passed None to the cluster helper, which then called .lower() and stopped compilation.

Testing

  • pytest tests/unit -q
  • Ruff format, lint, and mypy checks for changed files
  • YAML lint

@fallintoplace
fallintoplace force-pushed the fix/cluster-without-database-engine branch from 262de39 to 7e6fbeb Compare August 3, 2026 16:41
@koletzilla

Copy link
Copy Markdown
Contributor

Hi @fallintoplace thanks for your PRs!

Can you please:

  • Add a changelog to each of them similar as the rest of the rest of changelogs entries. As these are small fixes, please keep each changelog small.
  • Rebase your branch on top of latest main

@fallintoplace
fallintoplace force-pushed the fix/cluster-without-database-engine branch from 7e6fbeb to b505274 Compare August 3, 2026 16:53
@koletzilla

Copy link
Copy Markdown
Contributor

Thanks for the PR!

@koletzilla
koletzilla merged commit e89f23f into ClickHouse:main Aug 3, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants