Migration: move data-formats and dashboard assets to S3#325
Open
mintlify[bot] wants to merge 1 commit into
Open
Migration: move data-formats and dashboard assets to S3#325mintlify[bot] wants to merge 1 commit into
mintlify[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports clickhouse/clickhouse-docs#6489 to Mintlify: rewrites local
/assets/...and/examples/...-dashboard.jsonlinks to point at theclickhouse-docs-assetsS3 bucket, and removes the now-unused local files underassets/.Changes
clickstack/integration-examples/*,clickstack/managed-onboarding/monitoring-aws-cloudwatch-logs.mdx,products/managed-postgres/monitoring/prometheus.mdx):TrackedLink href={'/examples/<name>-dashboard.json'}→TrackedLink href={'https://clickhouse-docs-assets.s3.us-east-1.amazonaws.com/examples/<name>-dashboard.json'}.guides/clickhouse/data-formats/*): rewrote 37 markdown links from/assets/<file>→https://clickhouse-docs-assets.s3.us-east-1.amazonaws.com/<file>. Also normalizedarrays.jsonl→arrays.jsonandobject-per-line.jsonl(deleted, no refs remained) to match the exact S3 filenames used in the upstream PR.assets/(37 data-format files +cloudflare-logs-dashboard.json). Keptdata-otel-traces.csvandintegrations-fallback.json, which are Mintlify-only and out of scope.Notes / ambiguity
ar/,es/,fr/,ja/,ko/,pt-BR/,ru/,zh/) were not touched. TheirTrackedLink href={'/<locale>/examples/...'}and/assets/...references still point at local paths and will need a follow-up sweep if/when those locales are re-synced.guides/clickhouse/data-formats/json/formats.mdxpreviously linked toarrays.jsonl, but the upstream PR (and the S3 object confirmed 200 by the author) isarrays.json. I rewrote to the S3 form (arrays.json); double-check if intentional.get-started/quickstarts/working-with-the-map-type.mdxstill references/assets/data-otel-traces.csv; that file is not part of the upstream migration, so I left it in place.Context
Upstream reason: shrink the docs repo and host large binary/example assets on S3. All 52 migrated S3 URLs were link-checked and returned 200 in the source PR.