web: clear checking on the passwordless auto-login path - #232
Open
constkolesnyak wants to merge 1 commit into
Open
web: clear checking on the passwordless auto-login path#232constkolesnyak wants to merge 1 commit into
checking on the passwordless auto-login path#232constkolesnyak wants to merge 1 commit into
Conversation
`checking` starts true whenever there is no stored token, and App renders null while it is true. Every branch of checkAuth() clears it except the auto-login one taken when the server reports auth_required: false — so on a deployment with no password configured, a fresh browser logs in and then sits on a blank page until a manual reload seeds a token and skips the check entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On a deployment with no password configured, a fresh browser loads the web UI, auto-logs in, and then sits on a blank page. A manual reload fixes it.
The root cause:
checkingstarts as!getToken()(true for any browser without a stored token), soApp.tsxrendersnullwhile it is set. ThecheckAuth()branch that handles the passwordless auto-login path setsauthenticated: truebut never clearschecking, leaving the app stuck on a blank screen after a successful login.Fix
Clear
checking: falsealongsideauthenticated: truein the auto-login branch.Why
Correct UX — the app should render immediately after auto-login on a passwordless instance.
Rebased on current upstream/main (2026-07-30).