make systemd restart bounded so a self-restart cannot hang nerve down - #234
Open
constkolesnyak wants to merge 1 commit into
Open
make systemd restart bounded so a self-restart cannot hang nerve down#234constkolesnyak wants to merge 1 commit into
constkolesnyak wants to merge 1 commit into
Conversation
A bare SIGTERM in the systemd restart branch could hang the service indefinitely: uvicorn's graceful shutdown waits for in-flight connections to drain, and when restart is triggered from inside a live session, that session's own stream keeps a connection open, so the drain never completes. systemd's TimeoutStopSec->SIGKILL only escalates for a systemd-initiated stop, not for a process shutting itself down after a signal, so nothing forced the issue and the service stayed down. Spawn a detached helper (own session, survives the caller's death) that sends SIGTERM, waits up to 15s for a clean drain, then SIGKILLs. Once the old PID is gone, Restart=always brings up a fresh instance. Bounded, no privileges needed. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When nerve restarts itself via
nerve restart, the current implementation uses an unbounded helper script that can hang indefinitely if something goes wrong during startup. This change makes the restart bounded and systemd-aware: nerve signals systemd to respawn rather than launching an independent helper.Why
An unbounded self-restart can leave nerve in a stuck state with no recovery path. Making it systemd-aware lets the system's process supervisor handle failures and respawns correctly.
Rebased on current upstream/main (2026-07-30).