fix(tasks): preserve task metadata on completion - #238
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
fallintoplace
force-pushed
the
fix/task-done-preserve-metadata
branch
from
July 30, 2026 19:45
5acb99f to
d351fce
Compare
fallintoplace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Completing a task moves its Markdown file and calls
upsert_task()to refresh the SQLite index. Both completion paths supplied only the new path, status, title, and content.upsert_task()has replacement semantics, so the omitted values were written back as defaults. Completing a task therefore cleared its source, source URL, deadline, and tags. The missing tags also removed them from full-text search.Fix
Carry the metadata from the existing database row into the completion upsert in both
task_done_handler()andTaskManager.mark_done(). This keeps the change local to completion and leaves the intended replacement behavior ofupsert_task()unchanged.Verification
Added regression coverage for both completion paths that verifies:
memory/tasks/done/129 passedacross the task completion, task status, and database suites.