Split controld_remote_proxy_cb() into helper functions#4104
Merged
Conversation
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
To controld_remote_ra_in_maintenance(). Also return bool and take a const argument. Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
To controld_remote_ra_controlling_guest(). Also return bool and take a const argument. Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
clumens
reviewed
May 6, 2026
| /* This is msg from remote ipc client going to real ipc server */ | ||
|
|
||
| if (pcmk__str_eq(op, LRMD_IPC_OP_NEW, pcmk__str_casei)) { | ||
| if (pcmk__str_eq(op, LRMD_IPC_OP_NEW, pcmk__str_none)) { |
Contributor
There was a problem hiding this comment.
ACK, but it looks like there's a fair number of places where we're still comparing operations case-sensitively (grep -r pcmk__str_eq | grep _OP_). There doesn't appear to be any consistency to this. I suppose it's just things getting cleaned up as they're discovered.
Contributor
Author
There was a problem hiding this comment.
That's been exactly it.
I started to go change other comparisons just now, but I think it's going to create more conflicts in my other branches, and I'd rather not deal with that.
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
And clean up a couple of comments. Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
clumens
reviewed
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.