chore: make --exclude-allocations nicer to use - #490
Open
not-matthias wants to merge 3 commits into
Open
Conversation
Member
Author
|
@greptileai review |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Greptile SummaryMakes allocation exclusion opt-in while preserving explicit boolean values.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| src/cli/shared.rs | Configures both boolean options to accept bare flags or explicit equals-form values; the previously reported parsing failures are resolved. |
| src/cli/run/mod.rs | Aligns the test RunArgs fixture with the new false allocation-exclusion default. |
| src/executor/config.rs | Aligns the test orchestrator configuration with the new false allocation-exclusion default. |
| src/cli/experimental.rs | Updates deprecated-option documentation and warnings to avoid claiming allocation exclusion defaults to true. |
| src/upload/interfaces.rs | Clarifies that false allocation-exclusion metadata remains omitted for compatibility with legacy runs. |
Reviews (2): Last reviewed commit: "test: align exclude_allocations fixtures..." | Re-trigger Greptile
Merging this PR will not alter performance
|
Both flags used ArgAction::Set, which makes the value mandatory, so the bare form failed with "a value is required". require_equals is what keeps the now-optional value from swallowing the trailing bench command: without it, --exclude-allocations cargo bench parses cargo as the flag's value. Closes COD-3303
Allocation exclusion has defaulted to false since #489, but the deprecation warning still told users it defaults to true, and the serde-skip rationale still called --exclude-allocations=false the "opt-out path".
Both test() constructors still returned true, so tests exercised a configuration no default run produces.
not-matthias
force-pushed
the
cod-3303-make-exclude-allocations-easier-to-use
branch
from
July 29, 2026 13:54
5606467 to
6eac757
Compare
Member
Author
|
@greptileai review again |
GuillaumeLagrange
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before you had to pass =true or =false instead of just using --exclude-allocations