Skip to content

Glasgow | 26-ITP-May | Chan Yat Long | Sprint 1 | Form Control #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Motorcycle-lab wants to merge 6 commits into
base: main
Choose a base branch
from
+40 −10
Open

Glasgow | 26-ITP-May | Chan Yat Long | Sprint 1 | Form Control #1225

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
192cd43
Add form elements for user input 2
Motorcycle-lab May 5, 2026
240138f
Merge branch 'CodeYourFuture:main' into main
Motorcycle-lab May 5, 2026
66791a0
Fix HTML structure and update meta tags
Motorcycle-lab May 6, 2026
c955206
Fix input tag formatting in index.html
Motorcycle-lab May 6, 2026
ff8f2b9
Correction after review
Motorcycle-lab May 13, 2026
6454172
Refix the button and reput the name tag
May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 40 additions & 10 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,57 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="description" content="">
<meta name="viewport" content="width=device-width, initial-scale=1">
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<label for="user-name">Your Name:</label>
<input id="user-name" name="user-name" type="text" pattern="[A-Za-z\s\-]{2,}" title="Please enter at least 2 letters. Numbers and symbols are not allowed" required>


<br>

<label for="email">Your Email:</label>
<input id="email" name="user_email" type="email" required>

Comment thread
Poonam-raj marked this conversation as resolved.
<br>

<label for="colors">Choose your favorite color:</label>
<select id="colors" name="colour" required>
<option value="" disabled selected>Select a color...</option>
<option value="red">Red</option>
<option value="blue">Blue</option>
<option value="green">Green</option>
</select>

<br>

<label for="shirtsize">What size do you want?</label>

<select id="shirtsize" name="size" required>
<option value="" disabled selected>Select a size...</option>
<option value="s">S</option>
<option value="m">M</option>
<option value="l">L</option>
<option value="xl">XL</option>
<option value="xxl">XXL</option>
</select>

<button id="go" type="submit"> Submit
</button>

</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
<p>Chan Yat Long</p>
</footer>
</body>
</html>
Comment on lines 53 to 57
Copy link
Copy Markdown
Contributor

@Poonam-raj Poonam-raj May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take another look at this. Right now you have two footers when you should only have one with your name in it. Not comments should be left here either.

Image

One big issue is you have closed your html and body twice - delete the duplicate code.

Loading