Skip to content

London | 26-ITP-May | Gideon Defar | Sprint 1 | Form Control #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gideondefar wants to merge 10 commits into
base: main
Choose a base branch
from
+73 −25
Open

London | 26-ITP-May | Gideon Defar | Sprint 1 | Form Control #1289

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d845fd4
create form
gideondefar Jun 12, 2025
b9cc5f9
a strict validation rule
gideondefar Jun 13, 2025
6b3b802
lighthouse
gideondefar Jun 13, 2025
956c48d
pattern
gideondefar Jun 13, 2025
dbce8f7
footer text align to center
gideondefar Jun 13, 2025
a511293
rebase
gideondefar Jun 14, 2025
9057623
Fix missing newline at end of index.html
gideondefar May 16, 2026
fd5f1a4
Remove unnecessary empty line in style.css
gideondefar May 16, 2026
9388fc6
Fix CSS formatting by removing unnecessary closing brace
gideondefar May 16, 2026
a33f433
Fix CSS syntax for image grid column span
gideondefar May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 73 additions & 25 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,75 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
</footer>
</body>
</html>

<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="T-Shirt Order Form" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>

<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- Customer Name Input -->
<p>
<label for="customerName">Name:</label>
<input type="text" id="customerName" name="customerName" required minlength="2"
pattern=".*\S.*" placeholder="Enter your full name">
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the pattern so that it can reject names like "A " or " A"? (Name with only one non-space character but with many space characters)

</p>

<!-- Customer Email Input -->
<p>
<label for="emailAddress">Email:</label>
<input type="email" id="emailAddress" name="emailAddress" required placeholder="you@example.com"
pattern="^[a-zA-Z0-9._%+-]+@(?:[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?\.)+([a-zA-Z]{2,63})$"
title="Please enter a valid email address (e.g., user@example.com). Domain parts (like 'example') must start and end with a letter or number, can contain hyphens, and must be separated by dots. Ends with a top-level domain (e.g., .com).">
Comment on lines +28 to +30
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why specify the pattern when the input type is "email"? What difference does the pattern make?

When I tested the form, the input field still accepts "a@a" as a valid email.

</p>

<!-- T-Shirt Colour Selection -->
<fieldset>
<legend>Choose T-Shirt Colour:</legend>
<p>
<input type="radio" id="colourRed" name="shirtColour" value="red" required>
<label for="colourRed">Red</label>
Comment on lines +37 to +38
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id values should follow the "kebab-case" naming convention. For example: color-red.

Note: If you wrap <input> inside <label>, you would not need to introduce id.

</p>
<p>
<input type="radio" id="colourBlue" name="shirtColour" value="blue">
<label for="colourBlue">Blue</label>
</p>
<p>
<input type="radio" id="colourGreen" name="shirtColour" value="green">
<label for="colourGreen">Green</label>
</p>
</fieldset>

<!-- T-Shirt Size Selection -->
<p>
<label for="shirtSize">Choose Size:</label>
<select id="shirtSize" name="shirtSize" required>
<option value="">-- Please choose a size --</option>
<option value="xs">XS</option>
<option value="s">S</option>
<option value="m">M</option>
<option value="l">L</option>
<option value="xl">XL</option>
<option value="xxl">XXL</option>
</select>
</p>

<!-- Submit Section Button -->
<p>
<button type="submit">Place Order</button>
</p>
</form>
</main>
<footer>
<h2>By Gideon Defar</h2>
</footer>
</body>

</html>
Loading