London | ITP-May-2026 | Carolina Villa | Sprint 1 | Form Task#1295
Open
caro-vh wants to merge 8 commits into
Open
London | ITP-May-2026 | Carolina Villa | Sprint 1 | Form Task#1295caro-vh wants to merge 8 commits into
caro-vh wants to merge 8 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
caro-vh
added
📅 Sprint 1
cjyuan
added
Review in progress
cjyuan
reviewed
May 17, 2026
| name="full-name" | ||
| required | ||
| minlength="2" | ||
| pattern=".*\S,*\S.*" |
Contributor
There was a problem hiding this comment.
Can you change this pattern so that it can also accept a name like "C J" (two characters separated by a space)?
Comment on lines
+39
to
+40
| <input type="radio" id="red" name="colour" value="red" required> | ||
| <label for="red">red</label> |
Contributor
There was a problem hiding this comment.
Note: If you wrap the <input> element inside <label>, you would not need to introduce id.
cjyuan
added
Reviewed
Contributor
|
Can you edit the PR description so that the "Changelist" word is a level-2 header instead of a normal paragraph? Changelistinstead of Changelist |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Used form controls to collect customers data, such as t-shirt colour and size.