NW | 26-SDC-Mar | TzeMing Ho | Sprint 3 | Implement shell tools exercises#422
Open
TzeMingHo wants to merge 11 commits into
Open
NW | 26-SDC-Mar | TzeMing Ho | Sprint 3 | Implement shell tools exercises#422TzeMingHo wants to merge 11 commits into
TzeMingHo wants to merge 11 commits into
Conversation
TzeMingHo
added
📅 Sprint 3
SlideGauge
added
the
Review in progress
SlideGauge
reviewed
May 20, 2026
SlideGauge
left a comment
SlideGauge
left a comment
There was a problem hiding this comment.
I've got a couple of notes from my side could you fix them?
| let count = 1; | ||
|
|
||
| for (let path of pathsArray) { | ||
| const context = await fs.readFile(path, "utf-8"); |
There was a problem hiding this comment.
what will happen if file does not exist?
| const lines = context.trimEnd().split("\n"); | ||
| if (options.nonBlank) { | ||
| lines.forEach((line) => { | ||
| if (line.length != 0) { |
There was a problem hiding this comment.
what happens if i got a line consisting of whitespace?
| const fullPath = `${base.endsWith("/") ? base : base + "/"}${fileName}`; | ||
| const stats = await fs.stat(fullPath); | ||
| if (stats.isDirectory()) { | ||
| return `\x1b[1;34m${fileName}\x1b[0m`; |
There was a problem hiding this comment.
Good idea to use colour output, the only caveat we should output the color only if we are in terminal mode. I.e. right now if I pass it into a pipe, it will output these codes as well
| let numberOfWords = 0; | ||
| let numberOfCharacters = 0; | ||
|
|
||
| const file = await fs.readFile(path, "utf-8"); |
| const options = program.opts(); | ||
|
|
||
| function padStartNumbers(...args) { | ||
| const space = [3, 4, 4]; |
SlideGauge
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have completed the exercises.