Skip to content

fix(player): ensure we properly start one time midi playback #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Danielku15 merged 1 commit into from
May 23, 2026
Merged

fix(player): ensure we properly start one time midi playback #2708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions packages/alphatab/src/synth/AlphaSynth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,15 +294,14 @@ export class AlphaSynthBase implements IAlphaSynth {
this._notPlayedSamples += samples.length;
this.output.addSamples(samples);


// if the sequencer finished, we instantly force a noteOff on all
// voices to complete playback and stop voices fast.
// if the sequencer finished, we instantly force a noteOff on all
// voices to complete playback and stop voices fast.
// Doing this in the samplePlayed callback is too late as we might
// continue generating audio for long-release notes (especially percussion like cymbals)

// we still have checkForFinish which takes care of the counterpart
// on the sample played area to ensure we seek back.
// but thanks to this code we ensure the output will complete fast as we won't
// on the sample played area to ensure we seek back.
// but thanks to this code we ensure the output will complete fast as we won't
// be adding more samples beside a 0.1s ramp-down
if (this.sequencer.isFinished) {
this.synthesizer.noteOffAll(true);
Expand Down Expand Up @@ -403,6 +402,9 @@ export class AlphaSynthBase implements IAlphaSynth {
this._notPlayedSamples = 0;
this.output.resetSamples();

this.output.activate();
this._synthStopping = false;
this.state = PlayerState.Playing;
this.output.play();
}

Expand Down Expand Up @@ -577,6 +579,7 @@ export class AlphaSynthBase implements IAlphaSynth {

private _stopOneTimeMidi() {
this.output.pause();
this.output.resetSamples();
this.synthesizer.noteOffAll(true);
this.sequencer.resetOneTimeMidi();
this.timePosition = this.sequencer.currentTime;
Expand Down
Loading