fix: SC2059 in wizard (CI shellcheck default severity) - #3
Merged
Conversation
CI runs `shellcheck` at default severity (includes info-level), which flags variables in the printf format string. Use %s placeholders. The prior PR's static gate used `shellcheck -S warning`, which excludes info-level and missed this — now matched to the CI invocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line fix:
printfformat string used${RED}/${RST}variables directly, which CI's default-severityshellcheckflags as SC2059. Switched to%splaceholders. Verified with the exact CI commandshellcheck fixbuddy.sh fixbuddy-wizard.sh(clean) andbash -n.