feat(companion): add Magnetar PluginSdk resolution - #1
Open
maxpowa wants to merge 1 commit into
Open
Conversation
Resolve Magnetar's PluginSdk.dll for the companion project via a harness-supplied Magnetar install root, mirroring the existing DS64 resolution. Magnetar defaults to the per-user install path when not provided, and MagnetarBin is derived from it to locate PluginSdk.dll. Adds a validation target and documents the property in the README and Companion Channel guide. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
MagnetarMSBuild property to the companion project (src/TemplatePlugin.Magnetar) so it can reference Magnetar''sPluginSdk.dll, mirroring the existingDS64resolution added in bb11f91.Magnetar— supplied by the outer harness (Quasar); defaults to the per-user install root ($(APPDATA)\Magnetaron Windows,$(HOME)/.local/share/Magnetarotherwise) when not provided.MagnetarBin— derived fromMagnetarto locate the SDK directory (Libraries\MagnetarLegacyon Windows,Binotherwise); overridable for local dev.PluginSdkreference via$(MagnetarBin)and aValidateMagnetarReferencestarget matching the existing DS64 validation.Docs
README.md— companion-build notes and project-split bullet updated.docs/CompanionChannel.md—Magnetar/MagnetarBindocumented in the Owned Companion Builds section with an updated example.🤖 Generated with Claude Code