Skip to content

feat: add minimal SDXL txt2img workflow template - #15767

Open
neves-zz wants to merge 10 commits into
Comfy-Org:masterfrom
neves-zz:feat/add-sdxl-simple-workflow
Open

feat: add minimal SDXL txt2img workflow template#15767
neves-zz wants to merge 10 commits into
Comfy-Org:masterfrom
neves-zz:feat/add-sdxl-simple-workflow

Conversation

@neves-zz

@neves-zz neves-zz commented Aug 21, 2026

Copy link
Copy Markdown

Summary

Adds a minimal 7-node SDXL txt2img workflow template in API format (workflows/sdxl_simple.json), suitable for programmatic submission via POST /prompt.

Details

  • Node chain: CheckpointLoaderSimple → CLIPTextEncode (pos/neg) → EmptyLatentImage (1024²) → KSampler (dpmpp_2m/karras/25 steps/cfg 7) → VAEDecode → SaveImage
  • API format (top-level node-id map with class_type/inputs), not editor format

Notes

This is a personal convenience template; happy to adjust location/format if maintainers prefer a different convention.

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto‑billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink

comfyanonymous and others added 10 commits August 13, 2026 15:59
… extension (Comfy-Org#15579)

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
…logic (Comfy-Org#15655)

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Co-authored-by: Alexis Rolland <alexisrolland@hotmail.com>
Simple 7-node txt2img workflow (CheckpointLoaderSimple -> CLIP encode ->
EmptyLatentImage -> KSampler -> VAEDecode -> SaveImage) saved in API
format for programmatic submission via POST /prompt.
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Thank you for your contribution, we really appreciate it! 🎉

Like many open source projects, we require contributors to sign our Contributor License Agreement (CLA). A CLA makes the ownership of contributions explicit, so contributors and the project share a clear understanding of how the code can be used. By signing, you:

  • Confirm that you own your contribution.
  • Keep the right to reuse your own code.
  • Grant us a copyright license to include and share it within our projects.

CLAs are standard practice across major open source projects including those under the Apache Software Foundation and the Linux Foundation. Ours is based on the Apache Software Foundation's CLA. Most importantly, it would enable us to relicense the project under a more permissive license in the future, giving the project and its community greater flexibility.

To sign, please post a new comment on this PR with exactly the following text:


I have read and agree to the Contributor License Agreement


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4bab59f5-31af-4e89-a57f-0ef921735115

📥 Commits

Reviewing files that changed from the base of the PR and between 76135e5 and 6cc3501.

⛔ Files ignored due to path filters (2)
  • comfy_api_nodes/apis/bytedance.py is excluded by !comfy_api_nodes/apis/**
  • comfy_api_nodes/apis/fishaudio.py is excluded by !comfy_api_nodes/apis/**
📒 Files selected for processing (14)
  • comfy/model_prefetch.py
  • comfy_api_nodes/nodes_bfl.py
  • comfy_api_nodes/nodes_bytedance.py
  • comfy_api_nodes/nodes_fishaudio.py
  • comfy_api_nodes/nodes_grok.py
  • comfy_api_nodes/nodes_hitpaw.py
  • comfy_api_nodes/nodes_magnific.py
  • comfy_api_nodes/nodes_topaz.py
  • comfy_api_nodes/nodes_tripo.py
  • comfy_api_nodes/nodes_vidu.py
  • comfyui_version.py
  • pyproject.toml
  • requirements.txt
  • workflows/sdxl_simple.json
💤 Files with no reviewable changes (7)
  • comfy_api_nodes/nodes_tripo.py
  • comfy_api_nodes/nodes_vidu.py
  • comfy_api_nodes/nodes_hitpaw.py
  • comfy_api_nodes/nodes_magnific.py
  • comfy_api_nodes/nodes_bfl.py
  • comfy_api_nodes/nodes_grok.py
  • comfy_api_nodes/nodes_topaz.py

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📜 Recent review details
⚠️ CI failures not shown inline (2)

GitHub Actions: CLA Assistant / cla-assistant: feat: add minimal SDXL txt2img workflow template

Conclusion: failure

View job details

##[group]Run contributor-assistant/github-action@ca4a40a7d1004f18d9960b404b97e5f30a505a08
 with:
   path-to-document: https://github.com/Comfy-Org/comfy-cla/blob/main/comfyui_icla.md
   remote-organization-name: comfy-org
   remote-repository-name: comfy-cla
   path-to-signatures: signatures/cla.json
   branch: main
   allowlist: action@github.com,actions-user,ampagent,claude,comfy-pr-bot,GitHub Action,github-actions,github-actions[bot],Glary Bot,Glary-Bot,*[bot],alexisrolland,bigcat88,comfy-pr-bot,comfyanonymous,comfyui-wiki,fen-release[bot]
   custom-notsigned-prcomment: 🎉 Thank you for your contribution, we really appreciate it! 🎉
Like many open source projects, we require contributors to sign our [Contributor License Agreement (CLA)](https://github.com/Comfy-Org/comfy-cla/blob/main/comfyui_icla.md). A CLA makes the ownership of contributions explicit, so contributors and the project share a clear understanding of how the code can be used. By signing, you:
- Confirm that you own your contribution.
- Keep the right to reuse your own code.
- Grant us a copyright license to include and share it within our projects.
CLAs are standard practice across major open source projects including those under the Apache Software Foundation and the Linux Foundation. Ours is based on the Apache Software Foundation's CLA. Most importantly, it would enable us to relicense the project under a more permissive license in the future, giving the project and its community greater flexibility.
✍ **To sign, please post a new comment on this PR with exactly the following text:** ✍
   custom-pr-sign-comment: I have read and agree to the Contributor License Agreement
   custom-allsigned-prcomment: ✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged.
   use-dco-flag: false
   lock-pullrequest-aftermerge: true
   suggest-recheck: true
 env:
   GITHUB_***REDACTED_SECRET_ASSIGNMENT***
   PERSONAL_ACCESS_***REDACTED_SECRET_ASSIGNMENT***
 ##[endgroup]
 CLA Assistant...

GitHub Actions: CLA Assistant / 0_cla-assistant.txt: feat: add minimal SDXL txt2img workflow template

Conclusion: failure

View job details

##[group]Run contributor-assistant/github-action@ca4a40a7d1004f18d9960b404b97e5f30a505a08
 with:
   path-to-document: https://github.com/Comfy-Org/comfy-cla/blob/main/comfyui_icla.md
   remote-organization-name: comfy-org
   remote-repository-name: comfy-cla
   path-to-signatures: signatures/cla.json
   branch: main
   allowlist: action@github.com,actions-user,ampagent,claude,comfy-pr-bot,GitHub Action,github-actions,github-actions[bot],Glary Bot,Glary-Bot,*[bot],alexisrolland,bigcat88,comfy-pr-bot,comfyanonymous,comfyui-wiki,fen-release[bot]
   custom-notsigned-prcomment: 🎉 Thank you for your contribution, we really appreciate it! 🎉
Like many open source projects, we require contributors to sign our [Contributor License Agreement (CLA)](https://github.com/Comfy-Org/comfy-cla/blob/main/comfyui_icla.md). A CLA makes the ownership of contributions explicit, so contributors and the project share a clear understanding of how the code can be used. By signing, you:
- Confirm that you own your contribution.
- Keep the right to reuse your own code.
- Grant us a copyright license to include and share it within our projects.
CLAs are standard practice across major open source projects including those under the Apache Software Foundation and the Linux Foundation. Ours is based on the Apache Software Foundation's CLA. Most importantly, it would enable us to relicense the project under a more permissive license in the future, giving the project and its community greater flexibility.
✍ **To sign, please post a new comment on this PR with exactly the following text:** ✍
   custom-pr-sign-comment: I have read and agree to the Contributor License Agreement
   custom-allsigned-prcomment: ✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged.
   use-dco-flag: false
   lock-pullrequest-aftermerge: true
   suggest-recheck: true
 env:
   GITHUB_***REDACTED_SECRET_ASSIGNMENT***
   PERSONAL_ACCESS_***REDACTED_SECRET_ASSIGNMENT***
 ##[endgroup]
 CLA Assistant...
🧰 Additional context used
📓 Path-based instructions (7)
**/*

📄 CodeRabbit inference engine (AGENTS.md)

**/*: Keep changes small, direct, and limited to the narrowest necessary code path and smallest number of files.
Prefer practical fixes, minimal dependencies, and existing repository patterns; remove obsolete, dead, unreachable, or unused code.
Preserve existing APIs, node names, model-loading behavior, file layout, and workflow compatibility unless replacement is explicitly intended.
Core ComfyUI must not add outbound internet requests, telemetry, tracking, reporting, remote configuration, or background network activity. User-authorized model downloads are limited to the requested artifact and must exclude telemetry and unrelated metadata.

Files:

  • pyproject.toml
  • comfyui_version.py
  • comfy/model_prefetch.py
  • requirements.txt
  • workflows/sdxl_simple.json
  • comfy_api_nodes/nodes_fishaudio.py
  • comfy_api_nodes/nodes_bytedance.py
**

⚙️ CodeRabbit configuration file

**: IMPORTANT: Only comment on issues directly introduced by this PR's code changes.
Treat AGENTS.md as mandatory repository policy, not optional style guidance.
Flag PR changes that violate AGENTS.md even when the code is otherwise functional.
In particular, enforce architecture boundaries, dtype/device/memory rules,
interface contracts, import style, no unnecessary try/except blocks, no inline
imports, no outbound internet paths in core ComfyUI, and narrow scoped fixes.
Prefer direct findings over suggestions when a rule is violated. Only ignore
AGENTS.md when it clearly conflicts with a newer explicit maintainer instruction
in the PR.
Do NOT flag pre-existing issues in code that was merely moved, re-indented,
de-indented, or reformatted without logic changes. If code appears in the diff
only due to whitespace or structural reformatting (e.g., removing a with: block),
treat it as unchanged. Contributors should not feel obligated to address
pre-existing issues outside the scope of their contribution.

Files:

  • pyproject.toml
  • comfyui_version.py
  • comfy/model_prefetch.py
  • requirements.txt
  • workflows/sdxl_simple.json
  • comfy_api_nodes/nodes_fishaudio.py
  • comfy_api_nodes/nodes_bytedance.py
**/*.py

📄 CodeRabbit inference engine (AGENTS.md)

**/*.py: Keep state and capability flags on the object that owns the behavior. Prefer explicit parent-owned attributes over probing child objects with getattr; use child checks only when the child owns the delegated behavior.
Preserve shared method signatures, argument order, return shapes, side effects, and error behavior unless every affected caller and interface is intentionally updated.
Do not add unused compatibility parameters, flags, attributes, constructor options, or model-specific options to shared helpers; keep one-off behavior at the integration boundary.
Normalize third-party return conventions at integration boundaries so core code receives the expected type and shape; avoid undocumented caller-side unwrapping.
Do not add torch.no_grad, torch.inference_mode, or inference-mode wrappers. Do not add model freeze/unfreeze toggles; only disable globally enabled inference mode when a training path requires gradients.
Remove inference-only training behavior such as dropout while preserving checkpoint and state-dict compatibility; use nn.Identity when deleting a module would alter keys or ordering.
Keep imports at module scope except established optional-backend probes or imports required to avoid cycles; avoid unnecessary try/except blocks and use specific exceptions with useful fallbacks.
Do not add workarounds for unsupported library versions, especially PyTorch exception-and-float-cast retries, unless a comment names the exact versions still requiring them.
Let unsupported model formats, invalid quantization metadata, and bad states fail with clear errors instead of silently degrading output.
Match local style, keep comments sparse and useful, and remove comments that merely restate obvious code.
Treat dtype, device placement, VRAM use, and offloading as correctness concerns across CPU, CUDA, ROCm, MPS, DirectML, XPU, NPU, and low-VRAM environments.
Prefer existing ComfyUI and Comfy Kitchen operations, quantization helpers, cast/offload helpe...

Files:

  • comfyui_version.py
  • comfy/model_prefetch.py
  • comfy_api_nodes/nodes_fishaudio.py
  • comfy_api_nodes/nodes_bytedance.py
**/*.{py,json}

📄 CodeRabbit inference engine (AGENTS.md)

Treat legacy combo, io.Combo, and io.DynamicCombo values affecting filesystem access as untrusted; revalidate them at load/save boundaries with folder_paths, containment checks, or fixed allowlists.

Files:

  • comfyui_version.py
  • comfy/model_prefetch.py
  • workflows/sdxl_simple.json
  • comfy_api_nodes/nodes_fishaudio.py
  • comfy_api_nodes/nodes_bytedance.py
**/*.{py,md,txt,json}

📄 CodeRabbit inference engine (AGENTS.md)

Keep warning and info messages short and actionable, remove noisy or misleading logging, and make documentation edits concise, factual, and tied to changed behavior.

Files:

  • comfyui_version.py
  • comfy/model_prefetch.py
  • requirements.txt
  • workflows/sdxl_simple.json
  • comfy_api_nodes/nodes_fishaudio.py
  • comfy_api_nodes/nodes_bytedance.py
comfy/**

⚙️ CodeRabbit configuration file

comfy/**: Core ML/diffusion engine. Focus on:

  • Backward compatibility (breaking changes affect all custom nodes)
  • Memory management and GPU resource handling
  • Performance implications in hot paths
  • Thread safety for concurrent execution

Files:

  • comfy/model_prefetch.py
comfy_api_nodes/**

⚙️ CodeRabbit configuration file

comfy_api_nodes/**: Third-party API integration nodes. Focus on:

  • No hardcoded API keys or secrets
  • Proper error handling for API failures (timeouts, rate limits, auth errors)
  • Correct Pydantic model usage
  • Security of user data passed to external APIs

Files:

  • comfy_api_nodes/nodes_fishaudio.py
  • comfy_api_nodes/nodes_bytedance.py
🧠 Learnings (5)
📚 Learning: 2026-02-24T06:20:53.084Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI PR: 12604
File: requirements.txt:0-0
Timestamp: 2026-02-24T06:20:53.084Z
Learning: When reviewing Python dependency files, do not flag or comment on whether a package version exists on PyPI. Treat versions in requirements.txt as valid and focus reviews on correctness of syntax, formatting, and usage rather than PyPI availability.

Applied to files:

  • requirements.txt
📚 Learning: 2026-04-18T16:55:46.724Z
Learnt from: bigcat88
Repo: Comfy-Org/ComfyUI PR: 13465
File: comfy_api_nodes/nodes_bytedance.py:1496-1506
Timestamp: 2026-04-18T16:55:46.724Z
Learning: In `comfy_api_nodes` Python async node implementations (e.g., `async def execute`), synchronous CPU/IO-heavy helpers (such as video/audio trim/resize and base64/MP3 conversion) may be called directly without offloading to a thread executor (e.g., `asyncio.to_thread`). Treat this as an existing, broader refactor concern rather than a new PR regression: if the PR does not introduce additional synchronous blocking calls, reviewers should not flag it as a new issue. However, if the PR adds new synchronous CPU/IO work inside `async def execute`, prefer offloading with `asyncio.to_thread` (or an equivalent background executor) to avoid blocking the event loop.

Applied to files:

  • comfy_api_nodes/nodes_fishaudio.py
📚 Learning: 2026-08-14T20:00:13.296Z
Learnt from: bigcat88
Repo: Comfy-Org/ComfyUI PR: 15612
File: comfy_api_nodes/nodes_fishaudio.py:297-297
Timestamp: 2026-08-14T20:00:13.296Z
Learning: In partner nodes under comfy_api_nodes, do not flag direct calls from async def execute to shared audio/video conversion helpers such as audio_bytes_to_audio_input, audio_ndarray_to_bytesio, or audio_tensor_to_contiguous_ndarray as individual regressions. If event-loop offloading is needed, implement it centrally in the shared helpers under comfy_api_nodes/util as a dedicated refactor, preserving clean call sites across partner nodes.

Applied to files:

  • comfy_api_nodes/nodes_fishaudio.py
📚 Learning: 2026-08-11T17:33:31.657Z
Learnt from: bigcat88
Repo: Comfy-Org/ComfyUI PR: 15501
File: comfy_api_nodes/nodes_ltxv.py:213-217
Timestamp: 2026-08-11T17:33:31.657Z
Learning: When reviewing ComfyUI nodes that use IO.DynamicCombo, account for schema expansion by comfy_api/latest/_io.py::DynamicCombo._expand_schema_for_dynamic. Prompt validation in execution.py validates each resulting IO.Combo value against extra_info["options"] and rejects invalid values with value_not_in_list before execute() runs. Review validation logic against only the reachable option domain for closed IO.Combo.Input lists inside a DynamicCombo, unless the node provides another input path that bypasses prompt validation.

Applied to files:

  • comfy_api_nodes/nodes_fishaudio.py
📚 Learning: 2026-08-04T18:49:57.785Z
Learnt from: bigcat88
Repo: Comfy-Org/ComfyUI PR: 15295
File: comfy_api_nodes/nodes_bfl.py:1037-1051
Timestamp: 2026-08-04T18:49:57.785Z
Learning: When consuming dictionaries produced by IO.Autogrow.Type, rely on their iteration order to match the configured template-slot order. This ordering is preserved by _expand_schema_for_dynamic, parse_class_inputs, and build_nested_inputs, so consumers should iterate the dictionary directly when processing dynamic slots.

Applied to files:

  • comfy_api_nodes/nodes_fishaudio.py
🪛 ast-grep (0.45.1)
comfy_api_nodes/nodes_fishaudio.py

[info] 360-363: use jsonify instead of json.dumps for JSON output
Context: json.dumps(
[s.model_dump(exclude_none=True) for s in (response.segments or [])],
indent=2,
)
Note: [CWE-116] Improper Encoding or Escaping of Output.

(use-jsonify)

🔇 Additional comments (21)
workflows/sdxl_simple.json (1)

1-66: LGTM!

comfy/model_prefetch.py (1)

50-50: LGTM!

comfy_api_nodes/nodes_bytedance.py (7)

51-52: LGTM!

Also applies to: 118-118, 407-408


2057-2146: LGTM!


2207-2357: LGTM!


2433-2433: LGTM!

Also applies to: 2624-2624


2703-2808: LGTM!


2939-3005: LGTM!


3523-3523: LGTM!

comfyui_version.py (1)

3-3: LGTM!

pyproject.toml (1)

3-3: LGTM!

requirements.txt (1)

1-2: LGTM!

comfy_api_nodes/nodes_fishaudio.py (9)

26-66: LGTM!


69-130: LGTM!


133-178: LGTM!


181-251: LGTM!


253-297: LGTM!


300-339: LGTM!


341-365: LGTM!


368-439: LGTM!


442-454: LGTM!


📝 Walkthrough

Walkthrough

The pull request adds Fish Audio voice, speech, and cloning nodes. It expands Seedance 2.5 with 1080p support and explicit task types. It removes custom runtime price extraction from multiple API polling paths. It narrows CUDA graph prefetching to modules with _v_block. It updates project and dependency versions and adds an SDXL workflow.

Merge Risk: ⚪ Minimal · up to 6cc35

The PR adds an API-format SDXL txt2img workflow template, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 32 functions across 4 files. (3 skipped: 3 unsupported.) Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the addition of the minimal SDXL text-to-image workflow template, which is the stated primary objective.
Description check ✅ Passed The description accurately explains the SDXL workflow template, its node chain, API format, and intended programmatic use.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 2
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch feat/add-sdxl-simple-workflow
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants