Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add RUM and a compose file for fun reasons
Why
because we wanna squash profiles bug and then also compose file is nice
Test Plan
I got local stuff working with RUM
Env Vars
Yes,
DATADOG_ENVandDATADOG_VERSIONto set versions for RUM. These will be set in okd when it's merged(should be
devorprodand then tbh idk what to do for version)Documentation
Yes I wrote docs on compose files and
.envas well asDATADOG_ENVandDATADOG_VERSIONChecklist