Skip to content

Fix Oxygen Classic builder with custom fonts - #20

Open
Jan-CoreBunch wants to merge 1 commit into
CoreBunch:mainfrom
Jan-CoreBunch:fix/oxygen-classic-font-escaping
Open

Fix Oxygen Classic builder with custom fonts#20
Jan-CoreBunch wants to merge 1 commit into
CoreBunch:mainfrom
Jan-CoreBunch:fix/oxygen-classic-font-escaping

Conversation

@Jan-CoreBunch

Copy link
Copy Markdown
Contributor

Summary

  • HTML-escape the custom-font JSON injected into Oxygen Classic's ng-init attribute
  • prevent font-family quotes from corrupting Angular initialization and stalling the builder
  • add regression coverage for normal and special-character families, empty data, and disabled font integration

Validation

  • PHPUnit: 32 tests, 61 assertions
  • scoped PHPCS checks pass
  • PHP syntax and diff checks pass
  • manually verified Oxygen Classic loads and locally imported ABeeZee files return without console errors

Closes #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Oxygen Builder stuck on loading screen — 2.0 outputs elegantCustomFonts unescaped inside the ng-init attribute

1 participant