fix(validate): count label::<lang> columns as choice labels - #78
Merged
Merged
Conversation
The empty-label warning (#48) read only `choice.label`, so a choices sheet with language-tagged columns (`label::English`, Kobo's layout once a form declares a language) and no plain `label` got "has no label" for every choice, although the DDI labels were fine (found by survey2ddi's parity gate). The check now collects label text from `label` (string, or the loader's {lang: text}) and from every `label::<lang>` column. It warns when all are empty, or names the empty languages. Closes #75 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75. The empty-choice-label warning now reads
label::<lang>columns as well aslabel, so Kobo's language-tagged layout no longer warns on every choice. It still warns when all label columns are empty, and names the empty languages when only some are. 3 new tests; vitest and validate are clean.🤖 Generated with Claude Code