fix(lstsv2xlsform): reverse selected() on a multiple choice's native "other" - #81
Merged
Merged
Conversation
…"other" #80 changed the select_multiple_other example to selected(${q}, 'other'), which the forward path writes as (q_other.NAOK == 'Y'): the native "other" is LimeSurvey's implicit `other` subquestion. The reverse didn't know that code, read q_other as a separate question and produced selected(${q_other}, 'Y'), failing the round-trip contract test. #80 merged with that test failing (my merge chain didn't check the CI exit status). The selected() lookup now includes the implicit `other` code for every multiple choice with other=Y, so the relevance reverses to selected(${q}, 'other') again. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a failing test on
main.#80 merged with the
lstsv2xlsformround-trip contract test failing: my merge chain piped the CI check throughtail, which hid its exit status.Cause:
selected(${q}, 'other')on a multiple choice with nativeother=Yis written as(q_other.NAOK == 'Y').othercode, so it producedselected(${q_other}, 'Y').Fix: the reverse's
selected()lookup now includesotherfor every multiple choice withother=Y.vitest: 887 passed.
npm run validateis clean.🤖 Generated with Claude Code