fix(xlsform2lstsv): default group gets no invented description; --group-name - #83
Merged
Merged
Conversation
…up-name
A form without groups gets one group, because LimeSurvey needs every
question in a group. It was named "Questions" and also given "Questions" as
its description, text nobody wrote.
- The auto-created group's description is now empty; its name stays
defaults.groupName ("Questions" unless configured).
- CLI: xlsform2lstsv --group-name <text> sets it.
The "!Questions" title from the issue doesn't come from formtransform:
imported into LimeSurvey 6.16, the group is stored as group_name
"Questions" (checked live), so the "!" is added by whatever displays it.
Snapshots: the G row's text column is now empty in every entity and survey
without groups (13 + 2 files); nothing else changes. Live LimeSurvey suite
passes.
Closes #74
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74.
defaults.groupName, which is configurable in the library and now also on the CLI:xlsform2lstsv --group-name <text>.About "!Questions": I imported a group-less form into LimeSurvey 6.16 and read the group back. It's stored as
group_name: "Questions", so the!isn't from formtransform; it comes from whatever displays the title. Where did you see it?Snapshots: only the G row's
textchanges, in 13 entity and 2 survey snapshots.Tests: new tests for the configured name and the empty description. vitest passes. The live LimeSurvey suite passes: 102 passed. The qwacback live tests fail for an unrelated reason (qwacback now needs its
ddi-emittersidecar); fixed in a follow-up PR.🤖 Generated with Claude Code