test(live): retire the qwacback equivalence test; the swap is done - #84
Merged
Merged
Conversation
The test (ported from survey2ddi in #14) guarded qwacback's switch from its Go converter to this library. qwacback made that switch in CorrelAid/qwacback#3 (its ddi-emitter sidecar runs @correlaid/formtransform), so the test now compares the library with itself. It also broke: the qwacback image needs the sidecar (503 without it), and with it, `calculate` is now rejected by the DDI subset check qwacback runs, as intended. qwacback keeps its own equivalence check for its wiring (scripts/equivalence-test.mjs, internal/converter/ddi_client_test.go). tests/README.md says so; tests/live/qwacback/ is removed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retires
tests/live/qwacback/, the equivalence test that guarded qwacback's switch from its Go converter to this library.Why it can go: qwacback made the switch in CorrelAid/qwacback#3. Its
ddi-emittersidecar runs@correlaid/formtransform, so the test now compares the library with itself. The tests README had already planned to drop it at that point.It also broke:
calculatecase fails because qwacback now rejects it through the DDI subset check, which is intended.notestays an expected failure.qwacback keeps its own check for its wiring:
scripts/equivalence-test.mjsandinternal/converter/ddi_client_test.go.🤖 Generated with Claude Code