Follow-up to #51.
The PR/commit message for #51 describes three layers. Layer A (prompt) isn't in the commit. 3e398e3 only touches lead.ts, lead.test.ts, the e2e snapshot and one fixture. scripts/skill-content/generate-instructions.md:35 still has the old wording:
- Use `"Sonstiges"` + a follow-up `text` question with `relevant` logic instead of `or_other`
The hard rule described in the PR is missing: follow-up is required, named <parent>_sonstiges / <parent>_other, selected(${parent}, '<code>') vs ${parent} = '<code>', and the same for yes/no follow-ups. The generator gets no new guidance, so every broken follow-up has to be caught by the repair loop, and that loop has holes (see the related issues).
Minor: the new e2e fixture missing-relevant-on-follow-up only adds a snapshot of [] ("passes the formtransform validator"). It doesn't record that relevant is missing, so it doesn't document the failure mode the way the PR says it does.
Fix: apply the prompt change from the PR description to generate-instructions.md. Rebuild whatever is generated from it, and check that npm run test:e2e snapshots still match. Optionally, make the fixture assert that looksLikeFollowUp flags it.
Follow-up to #51.
The PR/commit message for #51 describes three layers. Layer A (prompt) isn't in the commit. 3e398e3 only touches
lead.ts,lead.test.ts, the e2e snapshot and one fixture.scripts/skill-content/generate-instructions.md:35still has the old wording:The hard rule described in the PR is missing: follow-up is required, named
<parent>_sonstiges/<parent>_other,selected(${parent}, '<code>')vs${parent} = '<code>', and the same for yes/no follow-ups. The generator gets no new guidance, so every broken follow-up has to be caught by the repair loop, and that loop has holes (see the related issues).Minor: the new e2e fixture
missing-relevant-on-follow-uponly adds a snapshot of[]("passes the formtransform validator"). It doesn't record thatrelevantis missing, so it doesn't document the failure mode the way the PR says it does.Fix: apply the prompt change from the PR description to
generate-instructions.md. Rebuild whatever is generated from it, and check thatnpm run test:e2esnapshots still match. Optionally, make the fixture assert thatlooksLikeFollowUpflags it.