Skip to content

#51 follow-up: prompt change (layer A) never landed in generate-instructions.md #52

Description

@jstet

Follow-up to #51.

The PR/commit message for #51 describes three layers. Layer A (prompt) isn't in the commit. 3e398e3 only touches lead.ts, lead.test.ts, the e2e snapshot and one fixture. scripts/skill-content/generate-instructions.md:35 still has the old wording:

- Use `"Sonstiges"` + a follow-up `text` question with `relevant` logic instead of `or_other`

The hard rule described in the PR is missing: follow-up is required, named <parent>_sonstiges / <parent>_other, selected(${parent}, '<code>') vs ${parent} = '<code>', and the same for yes/no follow-ups. The generator gets no new guidance, so every broken follow-up has to be caught by the repair loop, and that loop has holes (see the related issues).

Minor: the new e2e fixture missing-relevant-on-follow-up only adds a snapshot of [] ("passes the formtransform validator"). It doesn't record that relevant is missing, so it doesn't document the failure mode the way the PR says it does.

Fix: apply the prompt change from the PR description to generate-instructions.md. Rebuild whatever is generated from it, and check that npm run test:e2e snapshots still match. Optionally, make the fixture assert that looksLikeFollowUp flags it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions