wizard: further notes field and survey language selector (#40, #39) - #41
Merged
Merged
Conversation
Free-form textarea in phase 2 of the wizard for length limits, terms to avoid, or topics to focus on. Persisted across reloads and forwarded to the keyword and survey-generator prompts (with a matching rule in the xlsform skill instructions).
A new toggle in phase 3 picks the language of every question, label,
hint, choice, title, reasoning and rationale. Distinct from the existing
form-of-address toggle (Sie/Du): an English survey can address
respondents either way, and the German default is unchanged. The choice
is persisted across reloads and threaded into the generator prompt,
with a matching rule in the xlsform skill instructions ("prefer not to
answer" → "Keine Angabe" / "Prefer not to say", etc.).
Also adds an English-survey case to scripts/test_workflow.ts and updates
every existing AgentInput consumer for the new required field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small wizard additions, both opt-in and persisted across reloads.
Further notes/instructions (#40). Free-form textarea in phase 2 (Context) for length limits, terms to avoid, or topics to focus on. Forwarded to the keyword agent and the survey generator; the xlsform skill instructions gain a rule that says to follow the user's note, with conflicts flagged in
reasoning.Survey language selector (#39). New German/English toggle in phase 3 (Settings), above the existing form-of-address toggle (which now stays as Sie/Du). Persists; passed through to the generator prompt. The skill instructions swap their hard-coded German for language-relative phrasing:
"Keine Angabe"(de) /"Prefer not to say"(en),"Sonstiges"(de) /"Other"(en), rationale and reasoning insurveyLanguage, bank items adapted into the survey language. German is still the default — the qwac question bank is German-first.Other changes:
WizardInputsandAgentInputcarry the new fields.scripts/test_workflow.tsupdated for the now-requiredsurveyLanguageand gains an English-survey case.lead.test.tsfor both fields flowing through to the prompts.Verified:
npm run test:unit(82 pass),npm run test:e2e(45 pass),npm run check,npm run lint.Closes #40, #39.