wizard: pre-select the form-of-address default (#43) - #45
Merged
Merged
Conversation
The Sie/Du toggle used to start empty (language = null), which left both buttons unselected on first load. The agent call fell back to 'formal' anyway, so the empty state was just confusing UX. Default to 'formal' on first load and after a 'Clear form' reset; keep the storage type permissive (a stored 'null' from older sessions still loads and coalesces to 'formal'). Drop the now-redundant `language || 'formal'` at the call site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sie/Du toggle used to start empty (
language = null), leaving both buttons unselected on first load. The agent call fell back to'formal'anyway, so the empty state was just confusing UX.Default to
'formal'on first load and after a Clear form reset; keep the storage type permissive so a storednullfrom older sessions still loads and coalesces to'formal'. Drops the now-redundantlanguage || 'formal'at the call site.Verified:
npm run test:unit(82 pass),npm run test:e2e(45 pass),npm run check,npm run lint.Closes #43 (follow-up to #44).