skill: tell the generator not to reuse demographic variable names (#47) - #50
Merged
Merged
Conversation
Defensive follow-up to #49: the dedup strips generated questions that land on a demographic's name, but the prompt only told the model to avoid the topic. Add an explicit 'don't reuse the names either' clause with the concrete failure mode (sanitize would leave 'age' + 'age2' both with the German birth-date label) and a couple of rename hints ('birthyear', 'age_group', 'years_active'). The dedup stays as the safety net — the prompt nudges, the code guarantees.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defensive follow-up to #49: the dedup strips generated questions that land on a demographic's name, but the prompt only told the model to avoid the topic. Add an explicit "don't reuse the names either" clause with the concrete failure mode (sanitize would leave
age+age2both with the German birth-date label) and a couple of rename hints (birthyear,age_group,years_active).The dedup stays as the safety net — the prompt nudges, the code guarantees.
Verified:
npm run test:unit(91 pass),npm run test:e2e(45 pass),npm run check,npm run lint.