Pin schematron-worker tag in compose, publish ddi-emitter image (#8, #9) - #15
Merged
Merged
Conversation
docker-compose.yml tagged the worker with ${REGISTRY_VERSION:-local}.
Nothing sets REGISTRY_VERSION, so `docker compose up` pulled
ghcr.io/correlaid/schematron-worker:local, which doesn't exist. Pin the
tag literally and add scripts/check-registry-version.sh, which fails if
compose, ddi-emitter/package.json or package-lock.json disagree with
.registry-version. The release workflow runs it before building.
The published qwacback image depends on the ddi-emitter sidecar, but no
sidecar image was published. The release workflow now also builds and
pushes ghcr.io/correlaid/qwacback-ddi-emitter with the same tags.
Also:
- ddi-emitter image installs with `npm ci` from the lockfile, not
`npm install` from package.json alone.
- Drop ddi-emitter/.npmrc: `allow-remote=tarball` isn't a valid npm
setting and was ignored.
- Drop the meaningless local image tag on the ddi-emitter compose service.
Closes #8
Closes #9
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8, closes #9.
Summary
docker-compose.ymlpulledschematron-worker:${REGISTRY_VERSION:-local}. Nothing setsREGISTRY_VERSION, and the:localtag doesn't exist on GHCR, so a plaindocker compose upfailed. The tag is now pinned (v0.1.7). The newscripts/check-registry-version.shfails if compose,ddi-emitter/package.jsonorpackage-lock.jsondisagree with.registry-version. The release workflow runs it before building.ghcr.io/correlaid/qwacback-ddi-emitterwith the same tags. The README says to deploy it alongside qwacback and setDDI_EMITTER_URL.npm cifrom the lockfile.ddi-emitter/.npmrc:allow-remote=tarballisn't a valid npm setting, so npm ignored it.Verification
scripts/check-registry-version.shpasses. Changing the compose tag tov0.1.6makes it fail, as it should.docker compose configand the workflow YAML parse.npm ciand answers/healthz.main.Merges cleanly with #16 (sidecar hardening).
🤖 Generated with Claude Code