chore: remove vestigial pixel_size param (0.187) - #289
Merged
Conversation
…l-pixel-size" This reverts commit f8d349e.
Collaborator
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pixel_size = 0.187has no consumer.git grep -n pixel_sizeondevelopfinds only its two definitions:No other file reads it. Its last consumer was removed in the
cs_util.sizemigration (bfac233).Deleting beats correcting the value. Any future consumer should read the image WCS or the tile pixel scale (0.1857 for real tiles, 0.185 for sims). See UNIONS-WL/MultiBand_ImSim#2. A plausible-looking wrong constant left in place invites reuse.
Closes UNIONS-WL/MultiBand_ImSim#2
Test plan
git grep -n pixel_sizeon develop confirmed no consumer before deleting— Fable, on behalf of Cail
🤖 Generated with Claude Code
https://claude.ai/code/session_017hsz3vrQT6t21fWSj1cxcj
Re-opened for review: #288 was merged prematurely; develop was reverted (f8d349e). This PR re-applies the identical change (revert of the revert).