Skip to content

Tomographic rho-/tau-statistics #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sachaguer wants to merge 11 commits into
base: feature/sp_validation-extend-to-tomography
Choose a base branch
from
Open

Tomographic rho-/tau-statistics #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8ae222b
Start updating rho-tau-stats file for tomography
sachaguer Jul 21, 2026
d0b4ea9
Bring parent branch sp_validation-extend-to-tomography to the child b…
sachaguer Jul 21, 2026
0ce5416
Bring parent branch sp_validation-extend-to-tomography to the child b…
sachaguer Jul 21, 2026
4912b50
Update calculation function to work in tomographic context.
sachaguer Jul 21, 2026
d8b1507
Update plot scripts for tau-statistics to handle tomography. Validate…
sachaguer Jul 22, 2026
1e1a251
Fix typo in tomo bins col name
sachaguer Jul 22, 2026
813e448
Account for Copilot comments
sachaguer Jul 22, 2026
e26c37d
Clean pseudo-cl test with the modified parameter initialisation
sachaguer Jul 22, 2026
4559975
Reorganise functions in psf_systematics.py
sachaguer Jul 22, 2026
197d54c
Update the rho_tau_fits script to compute the tomographic PSF additiv…
sachaguer Jul 22, 2026
038f507
Update the rho_tau_fits script to compute the tomographic PSF additiv…
sachaguer Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cosmo_val/cat_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1280,7 +1280,7 @@ GLASS_mock_validation:
star_flag: FLAG_STAR_HSM
star_size: SIGMA_STAR_HSM
hdu: 1
path: unions_shapepipe_psf_2024_v1.6.a.fits
path: ../../../../n17data/UNIONS/WL/v1.6.x/unions_shapepipe_psf_2024_v1.6.a.fits
Comment thread
sachaguer marked this conversation as resolved.
ra_col: RA
dec_col: Dec
e1_PSF_col: E1_PSF_HSM
Expand Down
13 changes: 11 additions & 2 deletions src/sp_validation/cosmo_val/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,11 +483,20 @@ def results_objectwise(self):
self._results_objectwise = self.init_results(objectwise=True)
return self._results_objectwise

def basename(self, version, treecorr_config=None, npatch=None):
def basename(
self,
version,
tomo_bin_a="all",
tomo_bin_b=None,
treecorr_config=None,
npatch=None,
):
cfg = treecorr_config or self.treecorr_config
patches = npatch or self.npatch
tomo_bin_a_str = f"tomo_bin_{tomo_bin_a}"
tomo_bin_b_str = f"_tomo_bin_{tomo_bin_b}" if tomo_bin_b is not None else ""
return (
f"{version}_minsep={cfg['min_sep']}"
f"{version}_{tomo_bin_a_str}{tomo_bin_b_str}_minsep={cfg['min_sep']}"
f"_maxsep={cfg['max_sep']}"
Comment on lines +496 to 500

@sachaguer sachaguer Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have to be checked whether new outputs are read differently or if the call to open the file relies on the basename function as well.

f"_nbins={cfg['nbins']}"
f"_npatch={patches}"
Expand Down
2 changes: 1 addition & 1 deletion src/sp_validation/cosmo_val/pseudo_cl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1206,7 +1206,7 @@ def get_ell_factor(ell):
# Better jittering: symmetric around original ell values
jitter_fraction = (j - (len(versions) - 1) / 2) * offset
jittered_ell = ell + jitter_fraction * ell_widths
ell_factor_ = get_ell_factor(jittered_ell)
ell_factor_ = get_ell_factor(ell)

for pol in pol_list:
pol_color = self.get_pol_color(ver_color, pol, pol_list)
Expand Down
Loading
Loading