[pull] main from jason5ng32:main - #127
Merged
Merged
Conversation
tests/composable-globalping-measurement.test.js asserted after fixed sleeps that had to cover a POST plus up to three real pollInterval timers. "retries while in-progress" allowed 80ms for that chain and failed under a loaded parallel suite with status still 'running' — a wait that expired, reported as a wrong result. Measured 1 failure in 15 runs locally, and it failed two of three full `pnpm check` runs. waitFor() polls the same observable the assertion reads, so each test now takes as long as its work takes. Its timeout only bounds a hang. The disposal test had the opposite problem: its 10ms sleep could land before the POST resolved, leaving no pending timer for scope.stop() to cancel, so it could pass without exercising cancellation. It now waits for the create body to be read. Its trailing 80ms sleep stays — that one asserts an absence, which no condition can prove.
The disposal test asserted only that no poll fired, which onScopeDispose satisfies through `disposed` alone — poll() returns early on it. Deleting the clearTimeout left the whole test green, so the cancellation it is named for was unpinned. It now requires the scheduled poll timer itself to have been cleared.
Complete the remaining pt-BR translation datasets: - add the Security Checklist translation; - localize the complete release history. Preserve checklist slugs, priorities, links, and the beta locale status.
Add DNS.SB as a verified EU resolver with UDP and JSON DoH endpoints for #392. OpenAI Codex assisted with issue review, verification, implementation, and tests.
feat(dns): add DNS.SB resolver
sticky top-0 resolves against the scroll container's content box and never covers the container's own padding, so the results-state layout (where the padded wrapper itself became the scroll container) pushed the tally down by py-3. Split overflow and padding into separate layers so the scroll container is always padding-free, in all three Globalping-backed tools. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Add a curated Work & Productivity preset with 12 globally unique HTTPS targets, committed favicons, and locale labels. Refs #404. Co-authored-by: OpenAI Codex <noreply@openai.com>
…avior Both changes requested in review. waitFor was declared with `async function`; AGENTS.md requires new functions to use const arrow syntax, matching `tick` directly above it. The comment's middle paragraph narrated the removed 80ms sleep and the failure it produced. That history belongs to the PR, not the source. The remaining text states only the current constraint: the run spans a POST plus up to three real pollInterval timers, so no constant works, and the timeout only bounds a hang. Greptile's P1 on the `await tick()` before `scope.stop()` is deliberately not applied, per the maintainer's analysis: Node fires expired timers in expiry order and drains microtasks between callbacks, so the assertion, stop() and clearTimeout all complete before the 50ms poll could run. Removing the tick is the riskier direction. No behavior change. tests/composable-globalping-measurement.test.js 22/22; full `pnpm check` 1139/1139 plus build green. Re-ran the mutation control after the edit: deleting clearTimeout from cancel() still fails exactly the disposal case (21 pass, 1 fail), so the style change did not weaken it.
test(globalping): wait on conditions instead of fixed delays
Feat(connectivity): add productivity import list
Docs(readme): add Brazilian Portuguese README translation
Feat(i18n): complete Brazilian Portuguese locale coverage
The feature list had fallen behind the product (v7.x additions missing, stale copy) and 18 flat bullets scanned poorly. Regroup features into five sections, adopt GFM alerts for the required configuration, collapse the proxy rules into a details block, put Docker before Node, add the missing License section, and fix long-standing typos. All five translations are rebuilt from the new English text with tool names aligned to each UI locale pack, plus a community-maintained disclaimer. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- flip pt-BR to status:'full' in the locale registry - add pt-BR boot-screen quips and slow hint to index.html, and list it in the JSON-LD inLanguage - fill the productivity import-list name that landed after the pt-BR pack - swap TRANSLATING.md's new-language walkthrough example to es-MX now that pt-BR is a real full locale Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sync with Dev
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )