Skip to content

added a get events route and handler#5

Open
usmaan677 wants to merge 2 commits into
mainfrom
HomePageDisplay
Open

added a get events route and handler#5
usmaan677 wants to merge 2 commits into
mainfrom
HomePageDisplay

Conversation

@usmaan677
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Contributor

@ramseywiz ramseywiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small changes & questions

Comment thread src/services/profile.ts Outdated

async function getContactOrThrow(client: SupabaseClient, userId: string) {
const contact = await getContactByUserId(client, userId);
console.log(contact);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove these

Comment thread src/services/profile.ts Outdated
userId: string,
): Promise<MeResponse> {
const contact = await getContactOrThrow(client, userId);
console.log(contact);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove here as well

Comment thread src/index.ts Outdated
export default {
async fetch(request: Request, env: Env, ctx: ExecutionContext): Promise<Response> {
// Handle OPTIONS requests directly with CORS
if (request.method === "OPTIONS") {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this added ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My console was giving me a CORS Error this was a fix Ill try and remove it now and see if it still works

Comment thread .DS_Store
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this file? remove if not necessary pls

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.reddit.com/r/learnprogramming/comments/qniv8t/what_is_ds_store/

i found this thread lol, feel free to add this to the .gitignore

Comment thread src/db/profile.ts
Comment thread src/db/profile.ts
Copy link
Copy Markdown
Contributor

@ramseywiz ramseywiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants