Keep the non-modal ChatSidebar out of the background's way - #256
Merged
Conversation
React Aria's Modal always intercepts its backdrop — its dismissal props
only gate how it closes, never whether it blocks — so the default
non-modal sidebar locked the whole page behind it even though the
documented promise is that the background stays visible and interactive.
Render a plain portaled layer for modal={false}: same classes and data
attributes, no dialog semantics, no dismissal behavior at all, only the
close/back affordances dismiss it. The modal path is unchanged.
Add specs asserting a non-modal open sidebar leaves the background in
the accessibility tree and clickable, and that the modal one still hides
it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
ChatSidebaras a plain portaled layer instead of React Aria's modal overlay, so the default (non-modal) open sidebar no longer blocks the rest of the UI — the background stays visible and interactive, and only the close/back affordances dismiss it, as the documented behavior already promisedFixed
isDismissable={false}alone never made the background interactive